Message ID | A78C989F6D9628469189715575E55B236964FC78@IRSMSX104.ger.corp.intel.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 109827 invoked by alias); 5 Mar 2018 16:55:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 109810 invoked by uid 89); 5 Mar 2018 16:55:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mga04.intel.com Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Mar 2018 16:55:28 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2018 08:55:27 -0800 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga007.fm.intel.com with ESMTP; 05 Mar 2018 08:55:26 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX102.ger.corp.intel.com ([169.254.2.10]) with mapi id 14.03.0319.002; Mon, 5 Mar 2018 16:55:25 +0000 From: "Metzger, Markus T" <markus.t.metzger@intel.com> To: Alan Hayward <Alan.Hayward@arm.com> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, nd <nd@arm.com> Subject: RE: [PATCH v2 1/2] btrace: fix output of "set record btrace" Date: Mon, 5 Mar 2018 16:55:24 +0000 Message-ID: <A78C989F6D9628469189715575E55B236964FC78@IRSMSX104.ger.corp.intel.com> References: <1520247555-4643-1-git-send-email-markus.t.metzger@intel.com> <6BDA00D9-3EA2-4BCC-AA97-42547CFA808F@arm.com> In-Reply-To: <6BDA00D9-3EA2-4BCC-AA97-42547CFA808F@arm.com> x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGUzOWU4MDMtYzY2MC00ZjkyLWE2ZTEtOTE2OTM3YzAwNDYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIwUnB6ZlZcL0RaRGNieGlHS2J5YWNXQVpGQllMaU03TlhwdW5DdlBDODBPTVc1cUVNR1g3T3pLS1hQZTR4eUttbiJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes |
Commit Message
Metzger, Markus T
March 5, 2018, 4:55 p.m. UTC
Hello Alan, Thanks for your review. > > Instead of giving a message that "set record btrace" needs a > > sub-command, GDB crashed. Fix it. A regression test comes with the next > patch. > > > > 2018-03-05 Markus Metzger <markus.t.metzger@intel.com> > > > > gdb/ > > * record-btrace.c (cmd_set_record_btrace): Print sub-commands. > > --- > > gdb/record-btrace.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index > > 48eda54..905f0c4 100644 > > --- a/gdb/record-btrace.c > > +++ b/gdb/record-btrace.c > > @@ -2953,7 +2953,10 @@ cmd_record_btrace_start (const char *args, int > > from_tty) static void cmd_set_record_btrace (const char *args, int > > from_tty) { > > - cmd_show_list (set_record_btrace_cmdlist, from_tty, ""); > > + printf_unfiltered (_("\"set record btrace\" must be followed " > > + "by an apporpriate subcommand.\n")); > > appropriate not apporpriate. Thanks. I'm adding another patch to the series to fix that same typo in the "set record" command from where I took the message. See below. Looks like this text is not used in any test (grep did not find anything), except for the new gdb.btrace/cpu.exp that 2/2 of this series adds. Regards, Markus. --- commit 755376c12a2fa53d8304ff68265a09b8a332e965 Author: Markus Metzger <markus.t.metzger@intel.com> Date: Mon Mar 5 17:44:57 2018 +0100 record: fix typo in "set record" output Alan Hayward pointed out a typo in the output of "set record btrace" that I took from "set record". Fix the original. Signed-off-by: Markus Metzger <markus.t.metzger@intel.com> gdb/ * record.c (set_record_command): Fix typo in message. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928
Comments
> On 5 Mar 2018, at 16:55, Metzger, Markus T <markus.t.metzger@intel.com> wrote: > > Hello Alan, > > Thanks for your review. > >>> Instead of giving a message that "set record btrace" needs a >>> sub-command, GDB crashed. Fix it. A regression test comes with the next >> patch. >>> >>> 2018-03-05 Markus Metzger <markus.t.metzger@intel.com> >>> >>> gdb/ >>> * record-btrace.c (cmd_set_record_btrace): Print sub-commands. >>> --- >>> gdb/record-btrace.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index >>> 48eda54..905f0c4 100644 >>> --- a/gdb/record-btrace.c >>> +++ b/gdb/record-btrace.c >>> @@ -2953,7 +2953,10 @@ cmd_record_btrace_start (const char *args, int >>> from_tty) static void cmd_set_record_btrace (const char *args, int >>> from_tty) { >>> - cmd_show_list (set_record_btrace_cmdlist, from_tty, ""); >>> + printf_unfiltered (_("\"set record btrace\" must be followed " >>> + "by an apporpriate subcommand.\n")); >> >> appropriate not apporpriate. > > Thanks. I'm adding another patch to the series to fix that same typo in the > "set record" command from where I took the message. See below. > > Looks like this text is not used in any test (grep did not find anything), > except for the new gdb.btrace/cpu.exp that 2/2 of this series adds. > New patch LGTM. > Regards, > Markus. > > --- > > commit 755376c12a2fa53d8304ff68265a09b8a332e965 > Author: Markus Metzger <markus.t.metzger@intel.com> > Date: Mon Mar 5 17:44:57 2018 +0100 > > record: fix typo in "set record" output > > Alan Hayward pointed out a typo in the output of "set record btrace" that > I took from "set record". Fix the original. > > Signed-off-by: Markus Metzger <markus.t.metzger@intel.com> > > gdb/ > * record.c (set_record_command): Fix typo in message. > > diff --git a/gdb/record.c b/gdb/record.c > index cd83b99..aec2be3 100644 > --- a/gdb/record.c > +++ b/gdb/record.c > @@ -320,7 +320,7 @@ static void > set_record_command (const char *args, int from_tty) > { > printf_unfiltered (_("\"set record\" must be followed " > - "by an apporpriate subcommand.\n")); > + "by an appropriate subcommand.\n")); > help_list (set_record_cmdlist, "set record ", all_commands, gdb_stdout); > } > > Intel Deutschland GmbH > Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Christian Lamprechter > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >
diff --git a/gdb/record.c b/gdb/record.c index cd83b99..aec2be3 100644 --- a/gdb/record.c +++ b/gdb/record.c @@ -320,7 +320,7 @@ static void set_record_command (const char *args, int from_tty) { printf_unfiltered (_("\"set record\" must be followed " - "by an apporpriate subcommand.\n")); + "by an appropriate subcommand.\n")); help_list (set_record_cmdlist, "set record ", all_commands, gdb_stdout); }