[v2,1/2] btrace: fix output of "set record btrace"
Commit Message
Instead of giving a message that "set record btrace" needs a sub-command,
GDB crashed. Fix it. A regression test comes with the next patch.
2018-03-05 Markus Metzger <markus.t.metzger@intel.com>
gdb/
* record-btrace.c (cmd_set_record_btrace): Print sub-commands.
---
gdb/record-btrace.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Comments
> On 5 Mar 2018, at 10:59, Markus Metzger <markus.t.metzger@intel.com> wrote:
>
> Instead of giving a message that "set record btrace" needs a sub-command,
> GDB crashed. Fix it. A regression test comes with the next patch.
>
> 2018-03-05 Markus Metzger <markus.t.metzger@intel.com>
>
> gdb/
> * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
> ---
> gdb/record-btrace.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
> index 48eda54..905f0c4 100644
> --- a/gdb/record-btrace.c
> +++ b/gdb/record-btrace.c
> @@ -2953,7 +2953,10 @@ cmd_record_btrace_start (const char *args, int from_tty)
> static void
> cmd_set_record_btrace (const char *args, int from_tty)
> {
> - cmd_show_list (set_record_btrace_cmdlist, from_tty, "");
> + printf_unfiltered (_("\"set record btrace\" must be followed "
> + "by an apporpriate subcommand.\n"));
appropriate not apporpriate.
Otherwise, looks ok to me, and works when I tested it.
> + help_list (set_record_btrace_cmdlist, "set record btrace ",
> + all_commands, gdb_stdout);
> }
>
> /* The "show record btrace" command. */
> --
> 1.8.3.1
>
@@ -2953,7 +2953,10 @@ cmd_record_btrace_start (const char *args, int from_tty)
static void
cmd_set_record_btrace (const char *args, int from_tty)
{
- cmd_show_list (set_record_btrace_cmdlist, from_tty, "");
+ printf_unfiltered (_("\"set record btrace\" must be followed "
+ "by an apporpriate subcommand.\n"));
+ help_list (set_record_btrace_cmdlist, "set record btrace ",
+ all_commands, gdb_stdout);
}
/* The "show record btrace" command. */