Message ID | A78C989F6D9628469189715575E55B236964DF48@IRSMSX104.ger.corp.intel.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 118367 invoked by alias); 28 Feb 2018 12:53:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118357 invoked by uid 89); 28 Feb 2018 12:53:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=UD:el X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Feb 2018 12:53:23 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2018 04:53:18 -0800 X-ExtLoop1: 1 Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga008.jf.intel.com with ESMTP; 28 Feb 2018 04:53:17 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX107.ger.corp.intel.com ([169.254.10.46]) with mapi id 14.03.0319.002; Wed, 28 Feb 2018 12:53:16 +0000 From: "Metzger, Markus T" <markus.t.metzger@intel.com> To: "Maciej W. Rozycki" <macro@mips.com> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> Subject: RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method Date: Wed, 28 Feb 2018 12:53:15 +0000 Message-ID: <A78C989F6D9628469189715575E55B236964DF48@IRSMSX104.ger.corp.intel.com> References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <1516976072-19282-6-git-send-email-markus.t.metzger@intel.com> <alpine.DEB.2.00.1802241605470.3553@tp.orcam.me.uk> <A78C989F6D9628469189715575E55B236964BE94@IRSMSX104.ger.corp.intel.com> <m3bmgbpn0l.fsf@oc1027705133.ibm.com> <alpine.DEB.2.00.1802262138400.3553@tp.orcam.me.uk> <A78C989F6D9628469189715575E55B236964C660@IRSMSX104.ger.corp.intel.com> <alpine.DEB.2.00.1802271409010.3553@tp.orcam.me.uk> <A78C989F6D9628469189715575E55B236964DA03@IRSMSX104.ger.corp.intel.com> <alpine.DEB.2.00.1802280946150.3553@tp.orcam.me.uk> <alpine.DEB.2.00.1802281020420.3553@tp.orcam.me.uk> <A78C989F6D9628469189715575E55B236964DF04@IRSMSX104.ger.corp.intel.com> In-Reply-To: <A78C989F6D9628469189715575E55B236964DF04@IRSMSX104.ger.corp.intel.com> x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTNjZmM2ZTctNGZiYi00NTI0LTg2YzYtMzBmNWNlMjM5YTA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJVc1FnamlPWWZtZ0JlWEp3Z0lpczRtNkJcL3FPaDBGcW5kS2h2TXBWVFZvaWJCbDc4UFMweVlRNENPOVdxM0RoTCJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes |
Commit Message
Metzger, Markus T
Feb. 28, 2018, 12:53 p.m. UTC
Hello Maciej, I wondered why my fill-column auto-mode settings didn't seem to be effective and found that they were overwritten by gdb/.dir-locals.el. If you want to enforce the 74 columns limit, you may want to submit the below patch. I will leave the fill-column 74 for the commit-message but fall back to 80 columns for the rest. IIUC you were mostly concerned about the additional 4-columns indentation by 'git log'. Are you OK with that? Regards, Markus. --- > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Metzger, Markus T > Sent: 28 February 2018 12:24 > To: Maciej W. Rozycki <macro@mips.com> > Cc: gdb-patches@sourceware.org > Subject: RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace > target method > > Hello Maciej, > > I added > > (setq fill-column 74) > > for COMMIT_EDITMSG and for *.[hc] files. This excludes .exp and .texinfo (and > others), which are still at 80 columns. > > Also for command help-text strings I believe it makes sense to stay at 80 columns. > > Are you OK with that? > > Regards, > Markus. > > Intel Deutschland GmbH > Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of > the Supervisory Board: Nicole Lau Registered Office: Munich Commercial > Register: Amtsgericht Muenchen HRB 186928 Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928
Comments
Hi Markus, > I wondered why my fill-column auto-mode settings didn't seem to be effective and found > that they were overwritten by gdb/.dir-locals.el. > > If you want to enforce the 74 columns limit, you may want to submit the below patch. I don't use Emacs so I can't comment on technical details of your change, although at the high level it does look reasonable to me. > I will leave the fill-column 74 for the commit-message but fall back to 80 columns for the rest. > IIUC you were mostly concerned about the additional 4-columns indentation by 'git log'. > Are you OK with that? As I say we have the formatting rules set as documented in our wiki, so please do follow them, or if you want to get them changed, then you need to reach consensus about your proposal among GDB maintainers. Maciej
> From: "Metzger, Markus T" <markus.t.metzger@intel.com> > CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> > Date: Wed, 28 Feb 2018 12:53:15 +0000 > > I wondered why my fill-column auto-mode settings didn't seem to be effective and found > that they were overwritten by gdb/.dir-locals.el. > > If you want to enforce the 74 columns limit, you may want to submit the below patch. > > I will leave the fill-column 74 for the commit-message but fall back to 80 columns for the rest. > IIUC you were mostly concerned about the additional 4-columns indentation by 'git log'. > Are you OK with that? I believe this value is so we could some day produce ChangeLog files from Git log.
diff --git a/gdb/.dir-locals.el b/gdb/.dir-locals.el index 7e2b0cc..abfd167 100644 --- a/gdb/.dir-locals.el +++ b/gdb/.dir-locals.el @@ -21,6 +21,7 @@ (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s"))) (c-mode . ((c-file-style . "GNU") (mode . c++) + (fill-column . 74) (indent-tabs-mode . t) (tab-width . 8) (c-basic-offset . 2)