diff mbox

[07/19] Remove IS_IN_libc

Message ID 1408618663-2281-8-git-send-email-siddhesh@redhat.com
State Committed
Headers

Commit Message

Siddhesh Poyarekar Aug. 21, 2014, 10:57 a.m. UTC 
  Replace it with IS_IN_MODULE (libc) and remove the one place that it
is defined in.  The generated code remains unchanged on x86_64.

	* include/shlib-compat.h [!NOT_IN_libc]: Remove.
	* nss/nss_files/files-parse.c (IS_IN_libc): Replace with
	IS_IN (libc).
---
 include/shlib-compat.h      | 4 ----
 nss/nss_files/files-parse.c | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

Comments

Roland McGrath Aug. 22, 2014, 6:29 p.m. UTC | #1 
> Replace it with IS_IN_MODULE (libc) and remove the one place that it
> is defined in.  The generated code remains unchanged on x86_64.

Remember to fix this text (s/IS_IN_MODULE/IS_IN/) if it's part of your
commit log message.

The change and ChangeLog are fine.
diff mbox

Patch

diff --git a/include/shlib-compat.h b/include/shlib-compat.h
index 30804d3..062da8d 100644
--- a/include/shlib-compat.h
+++ b/include/shlib-compat.h
@@ -45,10 +45,6 @@ 
    && (!(ABI_##lib##_##obsoleted - 0)					      \
        || ((ABI_##lib##_##introduced - 0) < (ABI_##lib##_##obsoleted - 0))))
 
-# ifndef NOT_IN_libc
-#  define IS_IN_libc 1
-# endif
-
 /* That header also defines symbols like `VERSION_libm_GLIBC_2_1' to
    the version set name to use for e.g. symbols first introduced into
    libm in the GLIBC_2.1 version.  Definitions of symbols with explicit
diff --git a/nss/nss_files/files-parse.c b/nss/nss_files/files-parse.c
index 1da1a6f..42fd1f3 100644
--- a/nss/nss_files/files-parse.c
+++ b/nss/nss_files/files-parse.c
@@ -73,7 +73,7 @@  struct parser_data
 /* Export the line parser function so it can be used in nss_db.  */
 # define parser_stclass /* Global */
 # define parse_line CONCAT(_nss_files_parse_,ENTNAME)
-# ifdef IS_IN_libc
+# if IS_IN (libc)
 /* We are defining one of the functions that actually lives in libc
    because it is used to implement fget*ent and suchlike.  */
 #  define nss_files_parse_hidden_def(name) libc_hidden_def (name)