[4/4] S390: Document guarded-storage register support

Message ID 1506012057-7965-5-git-send-email-arnez@linux.vnet.ibm.com
State New, archived
Headers

Commit Message

Andreas Arnez Sept. 21, 2017, 4:40 p.m. UTC
  This documents the newly added support for guarded-storage registers on
IBM z.
---
 gdb/NEWS            | 3 +++
 gdb/doc/gdb.texinfo | 8 ++++++++
 2 files changed, 11 insertions(+)
  

Comments

Eli Zaretskii Sept. 21, 2017, 5 p.m. UTC | #1
> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
> Date: Thu, 21 Sep 2017 18:40:16 +0200
> 
> This documents the newly added support for guarded-storage registers on
> IBM z.
> ---
>  gdb/NEWS            | 3 +++
>  gdb/doc/gdb.texinfo | 8 ++++++++
>  2 files changed, 11 insertions(+)

This is OK, but please also include the ChangeLog changes which
reflect these.  (Actually, I see that you didn't include ChangeLog
entries for any of your changes.)

Thanks.
  
Andreas Arnez Sept. 21, 2017, 6:19 p.m. UTC | #2
On Thu, Sep 21 2017, Eli Zaretskii wrote:

>> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
>> Date: Thu, 21 Sep 2017 18:40:16 +0200
>> 
>> This documents the newly added support for guarded-storage registers on
>> IBM z.
>> ---
>>  gdb/NEWS            | 3 +++
>>  gdb/doc/gdb.texinfo | 8 ++++++++
>>  2 files changed, 11 insertions(+)
>
> This is OK, but please also include the ChangeLog changes which
> reflect these.  (Actually, I see that you didn't include ChangeLog
> entries for any of your changes.)

Oops.  For some reason I only included ChangeLog entries for the first
patch.  Right, I'll add the missing ones.

Thanks for reviewing the doc part.

--
Andreas
  
Andreas Arnez Sept. 25, 2017, 2:09 p.m. UTC | #3
On Thu, Sep 21 2017, Andreas Arnez wrote:

> On Thu, Sep 21 2017, Eli Zaretskii wrote:
>
>>> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
>>> Date: Thu, 21 Sep 2017 18:40:16 +0200
>>> 
>>> This documents the newly added support for guarded-storage registers on
>>> IBM z.
>>> ---
>>>  gdb/NEWS            | 3 +++
>>>  gdb/doc/gdb.texinfo | 8 ++++++++
>>>  2 files changed, 11 insertions(+)
>>
>> This is OK, but please also include the ChangeLog changes which
>> reflect these.  (Actually, I see that you didn't include ChangeLog
>> entries for any of your changes.)
>
> Oops.  For some reason I only included ChangeLog entries for the first
> patch.  Right, I'll add the missing ones.

OK, I pushed the series after adding the missing ChangeLog entries:

  https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=96235dc1ac3730c4e490d19db2e8287c0a40f307
  https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=1b63490c9173f8c9770b7885def720516aa9b9f8
  https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=ad3396348e0ebb61fdf71cff307bac08175ed366
  https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=289e23aa03084b22c73ebdcf18371f1e6666ead0

--
Andreas
  

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index 549f511..9246659 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,9 @@ 
 
 *** Changes since GDB 8.0
 
+* GDB now supports access to the guarded-storage-control registers and the
+  software-based guarded-storage broadcast control registers on IBM z14.
+
 * On Unix systems, GDB now supports transmitting environment variables
   that are to be set or unset to GDBserver.  These variables will
   affect the environment to be passed to the remote inferior.
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index d50a1fd..0bfaf61 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -41855,6 +41855,14 @@  through @samp{f15} to present the 128-bit wide vector registers
 contain the 128-bit wide vector registers @samp{v16} through
 @samp{v31}.
 
+The @samp{org.gnu.gdb.s390.gs} feature is optional.  It should contain
+the 64-bit wide guarded-storage-control registers @samp{gsd},
+@samp{gssm}, and @samp{gsepla}.
+
+The @samp{org.gnu.gdb.s390.gsbc} feature is optional.  It should contain
+the 64-bit wide guarded-storage broadcast control registers
+@samp{bc_gsd}, @samp{bc_gssm}, and @samp{bc_gsepla}.
+
 @node Sparc Features
 @subsection Sparc Features
 @cindex target descriptions, sparc32 features