[5/5] obstack usability

  When using obstack.h/c in other projects it isn't very nice that gnulib
headers like exitfail.h and gettext.h need to be present.  Far worse
is a dependency on gnulib's version of stdlib.h for __attribute_pure__
and _Noreturn.  This only works if a project is willing to import
rather a lot of gnulib configury magic, because gnulib's stdlib.h must
be modified at configure time.

	* lib/obstack.h (__attribute_pure__): Don't use _GL_ATTRIBUTE_PURE.
	* lib/obstack.c (obstack_exit_failure): Don't include exitfail.h.
	(_): Include libintl.h when HAVE_LIBINTL_H and ENABLE_NLS.  Don't
	include gettext.h.
	(_Noreturn): Define.
---
 lib/obstack.c |   29 +++++++++++++++++++++++------
 lib/obstack.h |    6 +++++-
 2 files changed, 28 insertions(+), 7 deletions(-)
  

Alan Modra <amodra@gmail.com> writes:

> +#   elif defined _MSC_VER && 1200 <= _MSC_VER

Please write that as "_MSC_VER >= 1200".

Andreas.
  

On Sat, Jul 26, 2014 at 09:20:36AM +0200, Andreas Schwab wrote:
> Alan Modra <amodra@gmail.com> writes:
> 
> > +#   elif defined _MSC_VER && 1200 <= _MSC_VER
> 
> Please write that as "_MSC_VER >= 1200".

Thanks for looking over the patch.  This line was taken out of
gnulib/m4/gnulib-common.m4..

I'm happy to fix this oddity and others like it, the tabs in
obstack.[ch] and formatting errors in a few places.
  

On 07/26/2014 01:57 AM, Alan Modra wrote:
> When using obstack.h/c in other projects it isn't very nice that gnulib
> headers like exitfail.h and gettext.h need to be present.  Far worse
> is a dependency on gnulib's version of stdlib.h for __attribute_pure__
> and _Noreturn.  This only works if a project is willing to import
> rather a lot of gnulib configury magic

Sure, but the downside of the proposed change is that it'd break 
programs like 'grep' that require the exitfail.h etc. semantics.

What projects are you thinking about?  That is, what current non-glibc 
projects have copies of obstack.h and obstack.c in their source code, 
but not exitfail.h etc.?
  

On 07/26/2014 07:21 AM, Alan Modra wrote:
>>> > >+#   elif defined _MSC_VER && 1200 <= _MSC_VER
>> >
>> >Please write that as "_MSC_VER >= 1200".
> Thanks for looking over the patch.  This line was taken out of
> gnulib/m4/gnulib-common.m4..
>
> I'm happy to fix this oddity and others like it,
I'd rather leave this alone.  This is a long-running disagreement about 
a minor style issue, and there's no need to impose the other style here.
  

Paul Eggert <eggert@cs.ucla.edu> writes:

> On 07/26/2014 07:21 AM, Alan Modra wrote:
>>>> > >+#   elif defined _MSC_VER && 1200 <= _MSC_VER
>>> >
>>> >Please write that as "_MSC_VER >= 1200".
>> Thanks for looking over the patch.  This line was taken out of
>> gnulib/m4/gnulib-common.m4..
>>
>> I'm happy to fix this oddity and others like it,
> I'd rather leave this alone.  This is a long-running disagreement about a
> minor style issue, and there's no need to impose the other style here.

This style is not suitable for high quality software.

Andreas.
  

On Sat, Jul 26, 2014 at 07:48:21AM -0400, Paul Eggert wrote:
> On 07/26/2014 01:57 AM, Alan Modra wrote:
> >When using obstack.h/c in other projects it isn't very nice that gnulib
> >headers like exitfail.h and gettext.h need to be present.  Far worse
> >is a dependency on gnulib's version of stdlib.h for __attribute_pure__
> >and _Noreturn.  This only works if a project is willing to import
> >rather a lot of gnulib configury magic
> 
> Sure, but the downside of the proposed change is that it'd break
> programs like 'grep' that require the exitfail.h etc. semantics.

Hmm, OK.

> What projects are you thinking about?  That is, what current
> non-glibc projects have copies of obstack.h and obstack.c in their
> source code, but not exitfail.h etc.?

binutils, gdb, and gcc via libiberty.  I guess we can live with a
patched obstack.[ch].