msp430: Don't use REG_UNKNOWN
Commit Message
This patch is cut from "[PATCH] Remove MAX_REGISTER_SIZE from regcache.c"
This patch simply makes it more obvious that msp430_pseudo_register_read ()
cannot return REG_UNKNOWN.
This is required due to some regcache refactoring (see the “Remove
MAX_REGISTER_SIZE from regcache.c" thread).
Tested on a --enable-targets=all build using make check with board files
unix and native-gdbserver.
I do not have a msp430 machine to test on.
Ok to commit?
Alan.
2017-04-06 Alan Hayward <alan.hayward@arm.com>
* msp430-tdep.c (msp430_pseudo_register_read): Never return
REG_UNKNOWN.
Comments
Alan Hayward <Alan.Hayward@arm.com> writes:
> Ok to commit?
>
> Alan.
>
> 2017-04-06 Alan Hayward <alan.hayward@arm.com>
>
> * msp430-tdep.c (msp430_pseudo_register_read): Never return
> REG_UNKNOWN.
Patch is good to me.
@@ -221,10 +221,9 @@ msp430_pseudo_register_read (struct gdbarch *gdbarch,
struct regcache *regcache,
int regnum, gdb_byte *buffer)
{
- enum register_status status = REG_UNKNOWN;
-
if (MSP430_NUM_REGS <= regnum && regnum < MSP430_NUM_TOTAL_REGS)
{
+ enum register_status status;
ULONGEST val;
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
int regsize = register_size (gdbarch, regnum);
@@ -234,11 +233,10 @@ msp430_pseudo_register_read (struct gdbarch *gdbarch,
if (status == REG_VALID)
store_unsigned_integer (buffer, regsize, byte_order, val);
+ return status;
}
else
gdb_assert_not_reached ("invalid pseudo register number");
-
- return status;
}
/* Implement the "pseudo_register_write" gdbarch method. */