[v9] amd64-mpx: initialize BND register before performing inferior calls.

Message ID 0f14f1c3-d99f-e83b-9b88-8453eccac66d@foss.arm.com
State New, archived
Headers

Commit Message

Jiong Wang March 8, 2017, 11:11 a.m. UTC
  On 27/02/17 17:15, Walfred Tedeschi wrote:
> +
> +@smallexample
> +     $ break *upper
> +     Breakpoint 2 at 0x4009de: file i386-mpx-call.c, line 47.
> +     $ print upper (a, b, c, d, 1)
> +     Breakpoint 2, upper (a=0x0, b=0x6e0000005b, c=0x0, d=0x0, len=48)....
> +     $ print $bnd0
> +     {lbound = 0x0, ubound = ffffffff} : size -1
> +@end smallexample

This caused "make html" failure, and it looks to me is missing @ before {.

I will commit this patch as obvious.

gdb/
2017-03-08  Jiong Wangg  <jiong.wang@arm.com>

         * doc/gdb.texinfo (Memory Protection Extensions): Add missing escape
         character "@".
  

Comments

Walfred Tedeschi March 8, 2017, 12:02 p.m. UTC | #1
Hello Jiong,

Thanks for doing that.
I have built the documentation as test as well. Not sure why this escaped.

Regards,
/Fred

-----Original Message-----
From: Jiong Wang [mailto:jiong.wang@foss.arm.com] 

Sent: Wednesday, March 8, 2017 11:11 AM
To: GDB <gdb-patches@sourceware.org>
Cc: Tedeschi, Walfred <walfred.tedeschi@intel.com>
Subject: Re: [PATCH v9] amd64-mpx: initialize BND register before performing inferior calls.

On 27/02/17 17:15, Walfred Tedeschi wrote:
> +

> +@smallexample

> +     $ break *upper

> +     Breakpoint 2 at 0x4009de: file i386-mpx-call.c, line 47.

> +     $ print upper (a, b, c, d, 1)

> +     Breakpoint 2, upper (a=0x0, b=0x6e0000005b, c=0x0, d=0x0, len=48)....

> +     $ print $bnd0

> +     {lbound = 0x0, ubound = ffffffff} : size -1 @end smallexample


This caused "make html" failure, and it looks to me is missing @ before {.

I will commit this patch as obvious.

gdb/
2017-03-08  Jiong Wangg  <jiong.wang@arm.com>

         * doc/gdb.texinfo (Memory Protection Extensions): Add missing escape
         character "@".

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
  

Patch

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index ba56ab282fcec17b3d703a4c53afd3fb14b14c37..5cf0f973bb5aaedd8ab3bd68ec2562f6046664fd 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -22574,7 +22574,7 @@  continuing the execution.  For example:
 	$ print upper (a, b, c, d, 1)
 	Breakpoint 2, upper (a=0x0, b=0x6e0000005b, c=0x0, d=0x0, len=48)....
 	$ print $bnd0
-	{lbound = 0x0, ubound = ffffffff} : size -1
+	@{lbound = 0x0, ubound = ffffffff@} : size -1
 @end smallexample
 
 At this last step the value of bnd0 can be changed for investigation of bound