Install libm.a as linker script [BZ #20539]

Message ID CAMe9rOqGZWgQhDQYO9NQBehG90dX4uTAjCwZdZ+xBn6hALgoZQ@mail.gmail.com
State New, archived
Headers

Commit Message

H.J. Lu Dec. 6, 2016, 9:48 p.m. UTC
  On Tue, Dec 6, 2016 at 7:49 AM, Andrew Senkevich
<andrew.n.senkevich@gmail.com> wrote:
> 2016-12-06 18:21 GMT+03:00 Andreas Schwab <schwab@suse.de>:
>> On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote:
>>
>>> 2016-12-06 17:17 GMT+03:00 Andreas Schwab <schwab@suse.de>:
>>>> On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote:
>>>>
>>>>> +2016-12-06  Andrew Senkevich  <andrew.senkevich@intel.com>
>>>>> +
>>>>> +     [BZ #20539]
>>>>> +     * math/Makefile (install-lib-ldscripts): added libm.a.
>>>>> +     ($(inst_libdir)/libm.a): added rule for installation as linker script.
>>>>> +     * Makerules (install-lib.a): filter out install-lib-ldscripts.
>>>>
>>>> ChangeLog entries should be in present tense, and written as full
>>>> sentences.
>>>
>>> Which sentence is not full?
>>
>> Full sentences start with a capital.
>
> Oh yes of course, fixed.
>
>
> --
> WBR,
> Andrew
  

Comments

Andrew Senkevich Dec. 7, 2016, 10:34 a.m. UTC | #1
2016-12-07 0:48 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
> On Tue, Dec 6, 2016 at 7:49 AM, Andrew Senkevich
> <andrew.n.senkevich@gmail.com> wrote:
>> 2016-12-06 18:21 GMT+03:00 Andreas Schwab <schwab@suse.de>:
>>> On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote:
>>>
>>>> 2016-12-06 17:17 GMT+03:00 Andreas Schwab <schwab@suse.de>:
>>>>> On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote:
>>>>>
>>>>>> +2016-12-06  Andrew Senkevich  <andrew.senkevich@intel.com>
>>>>>> +
>>>>>> +     [BZ #20539]
>>>>>> +     * math/Makefile (install-lib-ldscripts): added libm.a.
>>>>>> +     ($(inst_libdir)/libm.a): added rule for installation as linker script.
>>>>>> +     * Makerules (install-lib.a): filter out install-lib-ldscripts.
>>>>>
>>>>> ChangeLog entries should be in present tense, and written as full
>>>>> sentences.
>>>>
>>>> Which sentence is not full?
>>>
>>> Full sentences start with a capital.
>>
>> Oh yes of course, fixed.
>>
>>
>> --
>> WBR,
>> Andrew
>
> diff --git a/Makerules b/Makerules
> index e865782..573c074 100644
> --- a/Makerules
> +++ b/Makerules
> @@ -1190,7 +1190,8 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \
>   $(do-install-program)
>  endif
>  ifdef install-lib
> -install-lib.a := $(filter lib%.a,$(install-lib))
> +install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib)))
> +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a))
>
> Need to filler out libm.a separately since it is in install-lib-ldscripts
> already.

Oh surely, attached.


--
WBR,
Andrew
  

Patch

diff --git a/Makerules b/Makerules
index e865782..573c074 100644
--- a/Makerules
+++ b/Makerules
@@ -1190,7 +1190,8 @@  $(addprefix $(inst_sbindir)/,$(install-sbin)): \
  $(do-install-program)
 endif
 ifdef install-lib
-install-lib.a := $(filter lib%.a,$(install-lib))
+install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib)))
+install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a))

Need to filler out libm.a separately since it is in install-lib-ldscripts
already.