| Message ID | CAMXFM3u+VyNo0Y0DzZcZc0JaAqP8pqy44==Fg3dw0QxS=gzPaw@mail.gmail.com |
|---|---|
| State | New, archived |
| Headers |
Received: (qmail 91267 invoked by alias); 5 Dec 2016 19:40:28 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 91257 invoked by uid 89); 5 Dec 2016 19:40:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=WBR, H*f:sk:CAMXFM3, comfortable, UD:so$ X-HELO: mail-ua0-f193.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jDzDAV1jvwDTnYkG/j/lZZfDrfs4cJfhUcUnh0Ka4mM=; b=FbF+zVpvaQUQYht/DduWyn/tNQBqfFHDAkCqiGC79CddmQNQUoYlL+L0lP0skKM++I iijB7urgPQYU9ZvgglJLM28CjVR0qW834CaJ8xuCvi1SmsUjpw1dTYx2ZG7Wp/yLzpyx CYiXL66y5Itk4KCqSvGjziP8/1xMasA74PbVLsg0gOtUeA9s19+mX7jvRoUeOOV9CMre tP1iEJ6L9KiaDsBvfzZYro24JsRxtaPvFAsyFs1518QQoy5DoQl0uca8+M5sE8n/GhRp jWMNV6J/PbxDe+Qxw5zKbOM39QxBOZIsCCJ+AodxWeWclvdmfu3bWR+9LpMdFNPw/sSX pIxA== X-Gm-Message-State: AKaTC004U2zLhwf0sqFOcrJLmHCmUFJHZEDJ/s75+K3mF+/pzslSRfVfwCMttpCNg69SNDmRqhUzpx93zMY2yg== X-Received: by 10.159.33.1 with SMTP id 1mr45119310uab.134.1480966824989; Mon, 05 Dec 2016 11:40:24 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <CAMe9rOqirjhp+cpWGTVeQKd8p-yNdsO=mQ+-Ww-B4ULSjfUSWA@mail.gmail.com> References: <CAMXFM3szvCP13C1P_Ed8NVV_FTt4Q8avz4uW-a=UbpWqMnF5aw@mail.gmail.com> <CAMe9rOqirjhp+cpWGTVeQKd8p-yNdsO=mQ+-Ww-B4ULSjfUSWA@mail.gmail.com> From: Andrew Senkevich <andrew.n.senkevich@gmail.com> Date: Mon, 5 Dec 2016 22:39:54 +0300 Message-ID: <CAMXFM3u+VyNo0Y0DzZcZc0JaAqP8pqy44==Fg3dw0QxS=gzPaw@mail.gmail.com> Subject: Re: [PATCH] Install libm.a as linker script [BZ #20539] To: "H.J. Lu" <hjl.tools@gmail.com> Cc: libc-alpha <libc-alpha@sourceware.org> Content-Type: multipart/mixed; boundary=94eb2c0b7746877c3c0542ee75ba |
Commit Message
Andrew Senkevich
Dec. 5, 2016, 7:39 p.m. UTC
2016-10-25 1:02 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>: . . . > > Do you need to update rules for building static math tests with > libmvec.a? Currently where are no static tests linked with libmvec. Should we add such tests? Current patch is: $(libmvec) \ @@ -142,6 +142,18 @@ $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ 'AS_NEEDED ( $(libdir)/libmvec_nonshared.a $(slibdir)/libmvec.so$(libmvec.so-version) ) )' \ ) > $@.new mv -f $@.new $@ + +install-others = $(inst_libdir)/libm.a +$(inst_libdir)/libm.a: $(common-objpfx)format.lds \ + $(libm) \ + $(libmvec) \ + $(+force) + (echo '/* GNU ld script'; echo '*/';\ + cat $<; \ + echo 'GROUP ( $(libdir)/libm-$(lib-version).a $(libdir)/libmvec.a )' \ + ) > $@.new + cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a + mv -f $@.new $@ endif # Rules for the test suite. -- WBR, Andrew
Comments
On Mon, Dec 5, 2016 at 11:39 AM, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote: > 2016-10-25 1:02 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>: > . . . >> >> Do you need to update rules for building static math tests with >> libmvec.a? > > Currently where are no static tests linked with libmvec. > Should we add such tests? It is probably OK without it for now. > Current patch is: > > diff --git a/Makerules b/Makerules > index e865782..a670f81 100644 > --- a/Makerules > +++ b/Makerules > @@ -1190,7 +1190,10 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \ > $(do-install-program) > endif > ifdef install-lib > -install-lib.a := $(filter lib%.a,$(install-lib)) > +ifeq ($(build-mathvec),yes) > +install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib))) > +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a)) > +endif Will just ++ b/Makerules @@ -1191,6 +1191,7 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \ endif ifdef install-lib install-lib.a := $(filter lib%.a,$(install-lib)) +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a)) install-lib-non.a := $(filter-out lib%.a,$(install-lib)) ifdef install-lib-non.a $(addprefix $(inst_libdir)/$(libprefix),$(install-lib-non.a)): \ work? > install-lib-non.a := $(filter-out lib%.a,$(install-lib)) > ifdef install-lib-non.a > $(addprefix $(inst_libdir)/$(libprefix),$(install-lib-non.a)): \ > diff --git a/math/Makefile b/math/Makefile > index 848b093..77031b1 100644 > --- a/math/Makefile > +++ b/math/Makefile > @@ -128,10 +128,10 @@ generated += $(foreach s,.c .S,$(call > type-foreach, $(calls:s_%=m_%$(s)))) > routines = $(call type-foreach, $(calls)) > > ifeq ($(build-mathvec),yes) > -# We need to install libm.so as linker script > -# for more comfortable use of vector math library. > -install-lib-ldscripts := libm.so > -install_subdir: $(inst_libdir)/libm.so > +# We need to install libm.so and libm.a as linker scripts > +# for transparent use of vector math library. > +install-lib-ldscripts := libm.so libm.a > +install-others: $(inst_libdir)/libm.so $(inst_libdir)/libm.a > $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ > $(libm) \ > $(libmvec) \ > @@ -142,6 +142,18 @@ $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ > 'AS_NEEDED ( $(libdir)/libmvec_nonshared.a > $(slibdir)/libmvec.so$(libmvec.so-version) ) )' \ > ) > $@.new > mv -f $@.new $@ > + > +install-others = $(inst_libdir)/libm.a > +$(inst_libdir)/libm.a: $(common-objpfx)format.lds \ > + $(libm) \ > + $(libmvec) \ > + $(+force) > + (echo '/* GNU ld script'; echo '*/';\ > + cat $<; \ > + echo 'GROUP ( $(libdir)/libm-$(lib-version).a $(libdir)/libmvec.a )' \ > + ) > $@.new > + cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a > + mv -f $@.new $@ > endif > > # Rules for the test suite. > > > -- > WBR, > Andrew
2016-12-05 23:01 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>: > On Mon, Dec 5, 2016 at 11:39 AM, Andrew Senkevich > <andrew.n.senkevich@gmail.com> wrote: >> 2016-10-25 1:02 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>: >> . . . >>> >>> Do you need to update rules for building static math tests with >>> libmvec.a? >> >> Currently where are no static tests linked with libmvec. >> Should we add such tests? > > It is probably OK without it for now. > >> Current patch is: >> >> diff --git a/Makerules b/Makerules >> index e865782..a670f81 100644 >> --- a/Makerules >> +++ b/Makerules >> @@ -1190,7 +1190,10 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \ >> $(do-install-program) >> endif >> ifdef install-lib >> -install-lib.a := $(filter lib%.a,$(install-lib)) >> +ifeq ($(build-mathvec),yes) >> +install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib))) >> +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a)) >> +endif > > Will just > > ++ b/Makerules > @@ -1191,6 +1191,7 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \ > endif > ifdef install-lib > install-lib.a := $(filter lib%.a,$(install-lib)) > +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a)) > install-lib-non.a := $(filter-out lib%.a,$(install-lib)) > ifdef install-lib-non.a > $(addprefix $(inst_libdir)/$(libprefix),$(install-lib-non.a)): \ > > work? Yes, indeed. Attached fixed with updated ChangeLog, Ok for trunk? -- WBR, Andrew
On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote: > +2016-12-06 Andrew Senkevich <andrew.senkevich@intel.com> > + > + [BZ #20539] > + * math/Makefile (install-lib-ldscripts): added libm.a. > + ($(inst_libdir)/libm.a): added rule for installation as linker script. > + * Makerules (install-lib.a): filter out install-lib-ldscripts. ChangeLog entries should be in present tense, and written as full sentences. Andreas.
2016-12-06 17:17 GMT+03:00 Andreas Schwab <schwab@suse.de>: > On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote: > >> +2016-12-06 Andrew Senkevich <andrew.senkevich@intel.com> >> + >> + [BZ #20539] >> + * math/Makefile (install-lib-ldscripts): added libm.a. >> + ($(inst_libdir)/libm.a): added rule for installation as linker script. >> + * Makerules (install-lib.a): filter out install-lib-ldscripts. > > ChangeLog entries should be in present tense, and written as full > sentences. Which sentence is not full? -- WBR, Andrew
On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote: > 2016-12-06 17:17 GMT+03:00 Andreas Schwab <schwab@suse.de>: >> On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote: >> >>> +2016-12-06 Andrew Senkevich <andrew.senkevich@intel.com> >>> + >>> + [BZ #20539] >>> + * math/Makefile (install-lib-ldscripts): added libm.a. >>> + ($(inst_libdir)/libm.a): added rule for installation as linker script. >>> + * Makerules (install-lib.a): filter out install-lib-ldscripts. >> >> ChangeLog entries should be in present tense, and written as full >> sentences. > > Which sentence is not full? Full sentences start with a capital. Andreas.
2016-12-06 18:21 GMT+03:00 Andreas Schwab <schwab@suse.de>: > On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote: > >> 2016-12-06 17:17 GMT+03:00 Andreas Schwab <schwab@suse.de>: >>> On Dez 06 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote: >>> >>>> +2016-12-06 Andrew Senkevich <andrew.senkevich@intel.com> >>>> + >>>> + [BZ #20539] >>>> + * math/Makefile (install-lib-ldscripts): added libm.a. >>>> + ($(inst_libdir)/libm.a): added rule for installation as linker script. >>>> + * Makerules (install-lib.a): filter out install-lib-ldscripts. >>> >>> ChangeLog entries should be in present tense, and written as full >>> sentences. >> >> Which sentence is not full? > > Full sentences start with a capital. Oh yes of course, fixed. -- WBR, Andrew
diff --git a/Makerules b/Makerules index e865782..a670f81 100644 --- a/Makerules +++ b/Makerules @@ -1190,7 +1190,10 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \ $(do-install-program) endif ifdef install-lib -install-lib.a := $(filter lib%.a,$(install-lib)) +ifeq ($(build-mathvec),yes) +install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib))) +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a)) +endif install-lib-non.a := $(filter-out lib%.a,$(install-lib)) ifdef install-lib-non.a $(addprefix $(inst_libdir)/$(libprefix),$(install-lib-non.a)): \ diff --git a/math/Makefile b/math/Makefile index 848b093..77031b1 100644 --- a/math/Makefile +++ b/math/Makefile @@ -128,10 +128,10 @@ generated += $(foreach s,.c .S,$(call type-foreach, $(calls:s_%=m_%$(s)))) routines = $(call type-foreach, $(calls)) ifeq ($(build-mathvec),yes) -# We need to install libm.so as linker script -# for more comfortable use of vector math library. -install-lib-ldscripts := libm.so -install_subdir: $(inst_libdir)/libm.so +# We need to install libm.so and libm.a as linker scripts +# for transparent use of vector math library. +install-lib-ldscripts := libm.so libm.a +install-others: $(inst_libdir)/libm.so $(inst_libdir)/libm.a $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ $(libm) \