| Message ID | alpine.DEB.1.10.1406230137220.25395@tp.orcam.me.uk |
|---|---|
| State | Committed |
| Headers |
Received: (qmail 32428 invoked by alias); 23 Jun 2014 00:55:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 32416 invoked by uid 89); 23 Jun 2014 00:55:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Mon, 23 Jun 2014 01:54:56 +0100 From: "Maciej W. Rozycki" <macro@codesourcery.com> To: <libc-alpha@sourceware.org> Subject: [PATCH] stdlib/tst-strtod-overflow: Bump timeout up yet more Message-ID: <alpine.DEB.1.10.1406230137220.25395@tp.orcam.me.uk> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" |
Commit Message
Maciej W. Rozycki
June 23, 2014, 12:54 a.m. UTC
Hi, In our routine testing I observed that stdlib/tst-strtod-overflow is very slow, especially on targets using soft-float or QEMU (where soft-float is used internally), enough to time out even on slow boards we have that have TIMEOUTFACTOR already bumped from the default of 1 up to 75. No other test case requires such a long timeout -- all the other succeeding cases fit within their timeouts scaled by TIMEOUTFACTOR on these boards. As such I think it's counter-productive to require TIMEOUTFACTOR to be set as high as 450 globally for this lone outlier as the value affects overall testing duration where there are test cases that genuinely time out due to a defect. Therefore I propose the following change that makes stdlib/tst-strtod-overflow pass on these slow boards with TIMEOUTFACTOR of 75. OK to apply? 2014-06-23 Maciej W. Rozycki <macro@codesourcery.com> * stdlib/tst-strtod-overflow.c (TIMEOUT): Bump up to 30. Maciej
Comments
On Mon, 23 Jun 2014, Maciej W. Rozycki wrote: > In our routine testing I observed that stdlib/tst-strtod-overflow is very > slow, especially on targets using soft-float or QEMU (where soft-float is > used internally), enough to time out even on slow boards we have that have > TIMEOUTFACTOR already bumped from the default of 1 up to 75. > > No other test case requires such a long timeout -- all the other > succeeding cases fit within their timeouts scaled by TIMEOUTFACTOR on > these boards. As such I think it's counter-productive to require > TIMEOUTFACTOR to be set as high as 450 globally for this lone outlier as > the value affects overall testing duration where there are test cases that > genuinely time out due to a defect. Therefore I propose the following > change that makes stdlib/tst-strtod-overflow pass on these slow boards > with TIMEOUTFACTOR of 75. Ping! Maciej
On 30-06-2014 06:19, Maciej W. Rozycki wrote: > On Mon, 23 Jun 2014, Maciej W. Rozycki wrote: > >> In our routine testing I observed that stdlib/tst-strtod-overflow is very >> slow, especially on targets using soft-float or QEMU (where soft-float is >> used internally), enough to time out even on slow boards we have that have >> TIMEOUTFACTOR already bumped from the default of 1 up to 75. >> >> No other test case requires such a long timeout -- all the other >> succeeding cases fit within their timeouts scaled by TIMEOUTFACTOR on >> these boards. As such I think it's counter-productive to require >> TIMEOUTFACTOR to be set as high as 450 globally for this lone outlier as >> the value affects overall testing duration where there are test cases that >> genuinely time out due to a defect. Therefore I propose the following >> change that makes stdlib/tst-strtod-overflow pass on these slow boards >> with TIMEOUTFACTOR of 75. > Ping! > > Maciej > I don't have any objection to the patch, the explanation seems fair enough.
On Mon, 30 Jun 2014, Adhemerval Zanella wrote: > >> In our routine testing I observed that stdlib/tst-strtod-overflow is very > >> slow, especially on targets using soft-float or QEMU (where soft-float is > >> used internally), enough to time out even on slow boards we have that have > >> TIMEOUTFACTOR already bumped from the default of 1 up to 75. > >> > >> No other test case requires such a long timeout -- all the other > >> succeeding cases fit within their timeouts scaled by TIMEOUTFACTOR on > >> these boards. As such I think it's counter-productive to require > >> TIMEOUTFACTOR to be set as high as 450 globally for this lone outlier as > >> the value affects overall testing duration where there are test cases that > >> genuinely time out due to a defect. Therefore I propose the following > >> change that makes stdlib/tst-strtod-overflow pass on these slow boards > >> with TIMEOUTFACTOR of 75. > > Ping! > > > I don't have any objection to the patch, the explanation seems fair enough. Thanks for your input. Any other comments, anyone, or shall I treat it as the consensus? Maciej
On 1 July 2014 12:04, Maciej W. Rozycki <macro@codesourcery.com> wrote: > On Mon, 30 Jun 2014, Adhemerval Zanella wrote: > >> >> In our routine testing I observed that stdlib/tst-strtod-overflow is very >> >> slow, especially on targets using soft-float or QEMU (where soft-float is >> >> used internally), enough to time out even on slow boards we have that have >> >> TIMEOUTFACTOR already bumped from the default of 1 up to 75. >> >> >> >> No other test case requires such a long timeout -- all the other >> >> succeeding cases fit within their timeouts scaled by TIMEOUTFACTOR on >> >> these boards. As such I think it's counter-productive to require >> >> TIMEOUTFACTOR to be set as high as 450 globally for this lone outlier as >> >> the value affects overall testing duration where there are test cases that >> >> genuinely time out due to a defect. Therefore I propose the following >> >> change that makes stdlib/tst-strtod-overflow pass on these slow boards >> >> with TIMEOUTFACTOR of 75. >> > Ping! >> > >> I don't have any objection to the patch, the explanation seems fair enough. > > Thanks for your input. Any other comments, anyone, or shall I treat it > as the consensus? The change looks ok to me too.
On Tue, 1 Jul 2014, Will Newton wrote: > >> >> In our routine testing I observed that stdlib/tst-strtod-overflow is very > >> >> slow, especially on targets using soft-float or QEMU (where soft-float is > >> >> used internally), enough to time out even on slow boards we have that have > >> >> TIMEOUTFACTOR already bumped from the default of 1 up to 75. > >> >> > >> >> No other test case requires such a long timeout -- all the other > >> >> succeeding cases fit within their timeouts scaled by TIMEOUTFACTOR on > >> >> these boards. As such I think it's counter-productive to require > >> >> TIMEOUTFACTOR to be set as high as 450 globally for this lone outlier as > >> >> the value affects overall testing duration where there are test cases that > >> >> genuinely time out due to a defect. Therefore I propose the following > >> >> change that makes stdlib/tst-strtod-overflow pass on these slow boards > >> >> with TIMEOUTFACTOR of 75. > >> > Ping! > >> > > >> I don't have any objection to the patch, the explanation seems fair enough. > > > > Thanks for your input. Any other comments, anyone, or shall I treat it > > as the consensus? > > The change looks ok to me too. Applied now, thanks! Maciej
Index: glibc-fsf-trunk-quilt/stdlib/tst-strtod-overflow.c =================================================================== --- glibc-fsf-trunk-quilt.orig/stdlib/tst-strtod-overflow.c 2014-06-17 15:50:29.991694082 +0100 +++ glibc-fsf-trunk-quilt/stdlib/tst-strtod-overflow.c 2014-06-23 01:49:28.082011090 +0100 @@ -45,5 +45,5 @@ do_test (void) } #define TEST_FUNCTION do_test () -#define TIMEOUT 5 +#define TIMEOUT 30 #include "../test-skeleton.c"