Commit Message
Andreas Schwab pointed out earlier that not only is $(.) useless, it
also doesn't exist. Remove it.
Siddhesh
commit 0e9d2f7d62ae4483fff3d959f476cd455fe9da70
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date: Tue Jun 10 12:20:29 2014 +0530
Remove unnecessary $(.)
The variable is not necessary, especially since it does not exist.
Comments
Ping!
On Tue, Jun 10, 2014 at 12:21:54PM +0530, Siddhesh Poyarekar wrote:
> Andreas Schwab pointed out earlier that not only is $(.) useless, it
> also doesn't exist. Remove it.
>
> Siddhesh
>
> commit 0e9d2f7d62ae4483fff3d959f476cd455fe9da70
> Author: Siddhesh Poyarekar <siddhesh@redhat.com>
> Date: Tue Jun 10 12:20:29 2014 +0530
>
> Remove unnecessary $(.)
>
> The variable is not necessary, especially since it does not exist.
>
> diff --git a/ChangeLog b/ChangeLog
> index d693b04..eb9865f 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2014-06-10 Siddhesh Poyarekar <siddhesh@redhat.com>
> +
> + * benchtests/Makefile ($(objpfx)bench-%.c): Remove $(.).
> +
> 2014-06-09 Joseph Myers <joseph@codesourcery.com>
>
> * conform/data/termios.h-data [POSIX] (IUCLC): Do not expect
> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index fbcee13..c7b70c4 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -141,5 +141,5 @@ $(objpfx)bench-%.c: %-inputs $(bench-deps)
> { if [ -n "$($*-INCLUDE)" ]; then \
> cat $($*-INCLUDE); \
> fi; \
> - $(.)scripts/bench.py $(patsubst %-inputs,%,$<); } > $@-tmp
> + scripts/bench.py $(patsubst %-inputs,%,$<); } > $@-tmp
> mv -f $@-tmp $@
On 10 June 2014 07:51, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> Andreas Schwab pointed out earlier that not only is $(.) useless, it
> also doesn't exist. Remove it.
>
> Siddhesh
>
> commit 0e9d2f7d62ae4483fff3d959f476cd455fe9da70
> Author: Siddhesh Poyarekar <siddhesh@redhat.com>
> Date: Tue Jun 10 12:20:29 2014 +0530
>
> Remove unnecessary $(.)
>
> The variable is not necessary, especially since it does not exist.
Looks ok to me.
> diff --git a/ChangeLog b/ChangeLog
> index d693b04..eb9865f 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2014-06-10 Siddhesh Poyarekar <siddhesh@redhat.com>
> +
> + * benchtests/Makefile ($(objpfx)bench-%.c): Remove $(.).
> +
> 2014-06-09 Joseph Myers <joseph@codesourcery.com>
>
> * conform/data/termios.h-data [POSIX] (IUCLC): Do not expect
> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index fbcee13..c7b70c4 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -141,5 +141,5 @@ $(objpfx)bench-%.c: %-inputs $(bench-deps)
> { if [ -n "$($*-INCLUDE)" ]; then \
> cat $($*-INCLUDE); \
> fi; \
> - $(.)scripts/bench.py $(patsubst %-inputs,%,$<); } > $@-tmp
> + scripts/bench.py $(patsubst %-inputs,%,$<); } > $@-tmp
> mv -f $@-tmp $@
OK. I think this could have counted as "obvious enough".
@@ -1,3 +1,7 @@
+2014-06-10 Siddhesh Poyarekar <siddhesh@redhat.com>
+
+ * benchtests/Makefile ($(objpfx)bench-%.c): Remove $(.).
+
2014-06-09 Joseph Myers <joseph@codesourcery.com>
* conform/data/termios.h-data [POSIX] (IUCLC): Do not expect
@@ -141,5 +141,5 @@ $(objpfx)bench-%.c: %-inputs $(bench-deps)
{ if [ -n "$($*-INCLUDE)" ]; then \
cat $($*-INCLUDE); \
fi; \
- $(.)scripts/bench.py $(patsubst %-inputs,%,$<); } > $@-tmp
+ scripts/bench.py $(patsubst %-inputs,%,$<); } > $@-tmp
mv -f $@-tmp $@