Message ID | CAMe9rOr39A0tj5FgpC4Q-3a2EdTgbQorFdNzt6zq+ikZcG6qaA@mail.gmail.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 99534 invoked by alias); 4 Mar 2016 13:40:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 99524 invoked by uid 89); 4 Mar 2016 13:40:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qg0-f46.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=4zTuevVKurHSHNtt596Qh84xndsq6YRVqOGmpgZUy1Y=; b=gDCsOc85vHrvr+Goatw6eMkjLl1qC77hRq7/kf07VYstgMHNM5pWlZEfyl4Vs2/8C4 QEMoEbQpzLKhZkVVsln37hzVhIubYp5g8KwDmH+Cf4TDdOx+hX5xmUuPBBEq5rZkYRfd Jiyqm3QdDZZyTfWdXFLJxkKBCbsUhPfwqEe/n8qct4jFDzva3jxqTCetRLoetN5x5R6q yiQuzaMvO7WHZiJfupMquhxYUyS1b4Q5aSKSBK0ZsmmZFZC/eBJYGxwHc1y09N5AxzN2 eNYtLT3OjvMTyJ9NHiNhnOT8OKje1EQ+mA/b8ZKmRA3QIbeMSXB13iFzBNAyNSRFUcXT vQuQ== X-Gm-Message-State: AD7BkJJCEzOZEX1XSejwbawDCsmadnSbblgDGbizRbbuV8T8RfTV54Sm/SlpTe3MLtL8VBzUK1UsqAOEIoZJig== MIME-Version: 1.0 X-Received: by 10.140.19.52 with SMTP id 49mr9891094qgg.103.1457098811824; Fri, 04 Mar 2016 05:40:11 -0800 (PST) In-Reply-To: <20160304001930.4ED112C3C0B@topped-with-meat.com> References: <20160303134500.GA18701@intel.com> <20160304001016.658F62C3B4D@topped-with-meat.com> <CALoOobO+BO1GuZi7MB_L-mLSrMx8mpfDpAzJHtpgG2k1U=UGdA@mail.gmail.com> <20160304001930.4ED112C3C0B@topped-with-meat.com> Date: Fri, 4 Mar 2016 05:40:11 -0800 Message-ID: <CAMe9rOr39A0tj5FgpC4Q-3a2EdTgbQorFdNzt6zq+ikZcG6qaA@mail.gmail.com> Subject: Re: [PATCH] Copy x86_64 _mcount.op from _mcount.o From: "H.J. Lu" <hjl.tools@gmail.com> To: Roland McGrath <roland@hack.frob.com> Cc: Paul Pluzhnikov <ppluzhnikov@google.com>, GNU C Library <libc-alpha@sourceware.org> Content-Type: text/plain; charset=UTF-8 |
Commit Message
H.J. Lu
March 4, 2016, 1:40 p.m. UTC
On Thu, Mar 3, 2016 at 4:19 PM, Roland McGrath <roland@hack.frob.com> wrote: >> On Thu, Mar 3, 2016 at 4:10 PM, Roland McGrath <roland@hack.frob.com> wrote: >> >> > If I'd had a chance to review this change, I'd have said that I don't see >> > any adequate rationale for this change. >> >> It's a pre-condition for using ENTRY/END here: >> https://sourceware.org/ml/libc-alpha/2016-03/msg00055.html > > That needs to be said in the patch posting, and in comments in the makefile. Like this?
Comments
On Fri, Mar 4, 2016 at 5:40 AM, H.J. Lu <hjl.tools@gmail.com> wrote: > Like this? > > -- > H.J. > --- > diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile > index 9fcadd8..788e4fc 100644 > --- a/sysdeps/x86_64/Makefile > +++ b/sysdeps/x86_64/Makefile > @@ -7,6 +7,9 @@ endif > > ifeq ($(subdir),gmon) > sysdep_routines += _mcount > +# We cannot compile _mcount.S with -pg because that would create > +# recursive calls when ENTRY is used. Just copy the normal static > +# object. > sysdep_noprof += _mcount > endif Looks good to me. Thanks,
On Fri, Mar 4, 2016 at 8:02 AM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote: > On Fri, Mar 4, 2016 at 5:40 AM, H.J. Lu <hjl.tools@gmail.com> wrote: > >> Like this? >> >> -- >> H.J. >> --- >> diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile >> index 9fcadd8..788e4fc 100644 >> --- a/sysdeps/x86_64/Makefile >> +++ b/sysdeps/x86_64/Makefile >> @@ -7,6 +7,9 @@ endif >> >> ifeq ($(subdir),gmon) >> sysdep_routines += _mcount >> +# We cannot compile _mcount.S with -pg because that would create >> +# recursive calls when ENTRY is used. Just copy the normal static >> +# object. >> sysdep_noprof += _mcount >> endif > > Looks good to me. > > Thanks, > -- > Paul Pluzhnikov Checked in: commit 97f7112728fa6f5e2b30af4d085d5f4dedb2b89b Author: H.J. Lu <hjl.tools@gmail.com> Date: Fri Mar 4 08:44:43 2016 -0800 Add a comment in sysdeps/x86_64/Makefile Mention recursive calls when ENTRY is used in _mcount.S. * sysdeps/x86_64/Makefile (sysdep_noprof): Add a comment.
> > That needs to be said in the patch posting, and in comments in the makefile. > > Like this? That comment is a fine addition. The more important point for you to understand is the process issue of commits without proper review. I hope we don't have to have that conversation again in the future.
On Fri, Mar 4, 2016 at 10:21 AM, Roland McGrath <roland@hack.frob.com> wrote: >> > That needs to be said in the patch posting, and in comments in the makefile. >> >> Like this? > > That comment is a fine addition. The more important point for you to > understand is the process issue of commits without proper review. > I hope we don't have to have that conversation again in the future. Sure. BTW, should we do something about timely reviews?
diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile index 9fcadd8..788e4fc 100644 --- a/sysdeps/x86_64/Makefile +++ b/sysdeps/x86_64/Makefile @@ -7,6 +7,9 @@ endif ifeq ($(subdir),gmon) sysdep_routines += _mcount +# We cannot compile _mcount.S with -pg because that would create +# recursive calls when ENTRY is used. Just copy the normal static +# object. sysdep_noprof += _mcount endif