| Message ID | CAMXFM3u969ef7GtbFGaozg+mGTLCiYLo2WYUEFRq4jmBWVPw3w@mail.gmail.com |
|---|---|
| State | New, archived |
| Headers |
Received: (qmail 106177 invoked by alias); 16 Jan 2016 11:49:08 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 106162 invoked by uid 89); 16 Jan 2016 11:49:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=339, 33, 9, family, 2016-01-16 X-HELO: mail-lb0-f173.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=O+KwyP4sd5sC4clyTvkiMVqPWLcrb84EoaLrIRprfRU=; b=Zad1F5g9UrUjqWkOKgCHi3/hpIGnqN+kcCNe2MWtXqsTCQ0owntzzUVMIBgngw4Uul z6J+qeWiXQ3vIHEuMCQOoyeIbFavUgHe8H8eWvuTgW39hbB9z1O5tQJa5gsGPdmuZnDY iCAmhX2bxrfjvRBmtLCFZY/7gOmgJboCIx/PLShHI25EaaitiUmePEENvxexEfGvnSCa IkVwvjIv5RurwNdbxz9Wb/8eJv9nc05EuB99e4CaQ7xJlKaHfnX2ULRjQ74qLbGM2z7b P7npJ3SeS2pmotCcctYe/aJa7dTnrvz69M7tHiHRGKrJ0EiRltxr5UNB3xREcm9dwl19 nA/g== X-Gm-Message-State: ALoCoQl6hn/ATKAFXNQWZyWaClNA2r1wH4whCN17NbwocmMX4Z4Wk2dLOJxvieOb6i90ZIB0BSFvINx3Vld/ogfJa0Sg+TxftA== X-Received: by 10.112.180.138 with SMTP id do10mr5066774lbc.127.1452944943159; Sat, 16 Jan 2016 03:49:03 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <569971BB.5050702@redhat.com> References: <CAMXFM3uGLiFE+pKPzFgWP6Sx4C3w2Ktd4w3+35O0Bj=B1s0naA@mail.gmail.com> <CAMe9rOrTWce2vy0_OUWRH4FVRUSndpuSh2QpkmcMxgSBBEo0Fg@mail.gmail.com> <CAMXFM3tOe8UcRRoCQzLxHRt8o-azPQ=OJtHhFHGUDvsHAydoLQ@mail.gmail.com> <CAMe9rOreWU8eqsSaQShEY9+=Z6ySOTX+H8DxcYoFNY3i9tHrhg@mail.gmail.com> <CAMXFM3tH1FHdigHdYHVQiYafJMOf1=7Fxc+B2H1v11BNYxDgHw@mail.gmail.com> <CAMe9rOqeZtmz+LE5vbMSKJkid=7S4YmwR4=AzfuDFO07G6uF+w@mail.gmail.com> <CAMXFM3t9Y_YE_2zmPUr-agpMwhxk24OuU4QwY-zuWs-NKDEezA@mail.gmail.com> <569971BB.5050702@redhat.com> From: Andrew Senkevich <andrew.n.senkevich@gmail.com> Date: Sat, 16 Jan 2016 14:48:33 +0300 Message-ID: <CAMXFM3u969ef7GtbFGaozg+mGTLCiYLo2WYUEFRq4jmBWVPw3w@mail.gmail.com> Subject: Re: [PATCH] x86_64: memcpy/memmove family optimized with AVX512 To: Florian Weimer <fweimer@redhat.com> Cc: "H.J. Lu" <hjl.tools@gmail.com>, libc-alpha <libc-alpha@sourceware.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable |
Commit Message
Andrew Senkevich
Jan. 16, 2016, 11:48 a.m. UTC
2016-01-16 1:24 GMT+03:00 Florian Weimer <fweimer@redhat.com>: > On 01/15/2016 10:47 PM, Andrew Senkevich wrote: >> diff --git a/sysdeps/x86_64/multiarch/memcpy_chk.S b/sysdeps/x86_64/multiarch/memcpy_chk.S >> index 6476c62..a0d56d4 100644 >> --- a/sysdeps/x86_64/multiarch/memcpy_chk.S >> +++ b/sysdeps/x86_64/multiarch/memcpy_chk.S >> @@ -30,7 +30,15 @@ >> ENTRY(__memcpy_chk) >> .type __memcpy_chk, @gnu_indirect_function >> LOAD_RTLD_GLOBAL_RO_RDX >> - leaq __memcpy_chk_sse2(%rip), %rax >> +#ifdef HAVE_AVX512_ASM_SUPPORT >> + HAS_ARCH_FEATURE (AVX512F_Usable) >> + jz 1f >> +# HAS_ARCH_FEATURE (Prefer_No_VZEROUPPER) >> +# jz 1f > > The two lines starting with “#” look somewhat out of place. Is this > really intended? Florian, thank you, I have fixed it: -- WBR, Andrew
Comments
This patch appears to break my build: On Ubuntu 14.04 LTS, using system gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4: make[3]: Leaving directory '/Archive/glibc-git/elf' gcc -shared -static-libgcc -Wl,-O1 -Wl,-z,defs -Wl,-dynamic-linker=/lib64/ld-linux-x86-64.so.2 -B/Archive/glibc-git/build-system-gcc/csu/ -Wl,--version-script=/Archive/glibc-git/build-system-gcc/libc.map -Wl,-soname=libc.so.6 -Wl,-z,combreloc -Wl,-z,relro -Wl,--hash-style=both -nostdlib -nostartfiles -e __libc_main -L/Archive/glibc-git/build-system-gcc -L/Archive/glibc-git/build-system-gcc/math -L/Archive/glibc-git/build-system-gcc/elf -L/Archive/glibc-git/build-system-gcc/dlfcn -L/Archive/glibc-git/build-system-gcc/nss -L/Archive/glibc-git/build-system-gcc/nis -L/Archive/glibc-git/build-system-gcc/rt -L/Archive/glibc-git/build-system-gcc/resolv -L/Archive/glibc-git/build-system-gcc/crypt -L/Archive/glibc-git/build-system-gcc/mathvec -L/Archive/glibc-git/build-system-gcc/nptl -Wl,-rpath-link=/Archive/glibc-git/build-system-gcc:/Archive/glibc-git/build-system-gcc/math:/Archive/glibc-git/build-system-gcc/elf:/Archive/glibc-git/build-system-gcc/dlfcn:/Archive/glibc-git/build-system-gcc/nss:/Archive/glibc-git/build-system-gcc/nis:/Archive/glibc-git/build-system-gcc/rt:/Archive/glibc-git/build-system-gcc/resolv:/Archive/glibc-git/build-system-gcc/crypt:/Archive/glibc-git/build-system-gcc/mathvec:/Archive/glibc-git/build-system-gcc/nptl -o /Archive/glibc-git/build-system-gcc/libc.so -T /Archive/glibc-git/build-system-gcc/shlib.lds /Archive/glibc-git/build-system-gcc/csu/abi-note.o /Archive/glibc-git/build-system-gcc/elf/soinit.os /Archive/glibc-git/build-system-gcc/libc_pic.os /Archive/glibc-git/build-system-gcc/elf/sofini.os /Archive/glibc-git/build-system-gcc/elf/interp.os /Archive/glibc-git/build-system-gcc/elf/ld.so -lgcc /Archive/glibc-git/build-system-gcc/libc_pic.os: In function `__libc_ifunc_impl_list': /Archive/glibc-git/misc/../sysdeps/x86_64/multiarch/ifunc-impl-list.c:50: undefined reference to `__memmove_chk_avx512_no_vzeroupper' /usr/bin/ld: /Archive/glibc-git/build-system-gcc/libc_pic.os: relocation R_X86_64_PC32 against undefined hidden symbol `__memmove_chk_avx512_no_vzeroupper' can not be used when making a shared object /usr/bin/ld: final link failed: Bad value collect2: error: ld returned 1 exit status ../Makerules:681: recipe for target '/Archive/glibc-git/build-system-gcc/libc.so' failed make[2]: *** [/Archive/glibc-git/build-system-gcc/libc.so] Error 1 make[2]: Leaving directory '/Archive/glibc-git/elf' Makefile:214: recipe for target 'elf/subdir_lib' failed make[1]: *** [elf/subdir_lib] Error 2 make[1]: Leaving directory '/Archive/glibc-git' Makefile:9: recipe for target 'all' failed make: *** [all] Error 2 On Sat, Jan 16, 2016 at 3:48 AM, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote: > 2016-01-16 1:24 GMT+03:00 Florian Weimer <fweimer@redhat.com>: >> On 01/15/2016 10:47 PM, Andrew Senkevich wrote: >>> diff --git a/sysdeps/x86_64/multiarch/memcpy_chk.S b/sysdeps/x86_64/multiarch/memcpy_chk.S >>> index 6476c62..a0d56d4 100644 >>> --- a/sysdeps/x86_64/multiarch/memcpy_chk.S >>> +++ b/sysdeps/x86_64/multiarch/memcpy_chk.S >>> @@ -30,7 +30,15 @@ >>> ENTRY(__memcpy_chk) >>> .type __memcpy_chk, @gnu_indirect_function >>> LOAD_RTLD_GLOBAL_RO_RDX >>> - leaq __memcpy_chk_sse2(%rip), %rax >>> +#ifdef HAVE_AVX512_ASM_SUPPORT >>> + HAS_ARCH_FEATURE (AVX512F_Usable) >>> + jz 1f >>> +# HAS_ARCH_FEATURE (Prefer_No_VZEROUPPER) >>> +# jz 1f >> >> The two lines starting with “#” look somewhat out of place. Is this >> really intended? > > Florian, thank you, I have fixed it: > > diff --git a/sysdeps/x86_64/multiarch/memcpy_chk.S > b/sysdeps/x86_64/multiarch/memcpy_chk.S > index a0d56d4..648217e 100644 > --- a/sysdeps/x86_64/multiarch/memcpy_chk.S > +++ b/sysdeps/x86_64/multiarch/memcpy_chk.S > @@ -33,9 +33,9 @@ ENTRY(__memcpy_chk) > #ifdef HAVE_AVX512_ASM_SUPPORT > HAS_ARCH_FEATURE (AVX512F_Usable) > jz 1f > -# HAS_ARCH_FEATURE (Prefer_No_VZEROUPPER) > -# jz 1f > - leaq __memcpy_avx512_no_vzeroupper(%rip), %rax > + HAS_ARCH_FEATURE (Prefer_No_VZEROUPPER) > + jz 1f > + leaq __memcpy_chk_avx512_no_vzeroupper(%rip), %rax > ret > #endif > 1: leaq __memcpy_chk_sse2(%rip), %rax > > > -- > WBR, > Andrew
On Mon, Jan 18, 2016 at 10:50 AM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote: > This patch appears to break my build: > > On Ubuntu 14.04 LTS, using system gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4: > > > make[3]: Leaving directory '/Archive/glibc-git/elf' > gcc -shared -static-libgcc -Wl,-O1 -Wl,-z,defs > -Wl,-dynamic-linker=/lib64/ld-linux-x86-64.so.2 > -B/Archive/glibc-git/build-system-gcc/csu/ > -Wl,--version-script=/Archive/glibc-git/build-system-gcc/libc.map > -Wl,-soname=libc.so.6 -Wl,-z,combreloc -Wl,-z,relro > -Wl,--hash-style=both -nostdlib -nostartfiles -e __libc_main > -L/Archive/glibc-git/build-system-gcc > -L/Archive/glibc-git/build-system-gcc/math > -L/Archive/glibc-git/build-system-gcc/elf > -L/Archive/glibc-git/build-system-gcc/dlfcn > -L/Archive/glibc-git/build-system-gcc/nss > -L/Archive/glibc-git/build-system-gcc/nis > -L/Archive/glibc-git/build-system-gcc/rt > -L/Archive/glibc-git/build-system-gcc/resolv > -L/Archive/glibc-git/build-system-gcc/crypt > -L/Archive/glibc-git/build-system-gcc/mathvec > -L/Archive/glibc-git/build-system-gcc/nptl > -Wl,-rpath-link=/Archive/glibc-git/build-system-gcc:/Archive/glibc-git/build-system-gcc/math:/Archive/glibc-git/build-system-gcc/elf:/Archive/glibc-git/build-system-gcc/dlfcn:/Archive/glibc-git/build-system-gcc/nss:/Archive/glibc-git/build-system-gcc/nis:/Archive/glibc-git/build-system-gcc/rt:/Archive/glibc-git/build-system-gcc/resolv:/Archive/glibc-git/build-system-gcc/crypt:/Archive/glibc-git/build-system-gcc/mathvec:/Archive/glibc-git/build-system-gcc/nptl > -o /Archive/glibc-git/build-system-gcc/libc.so -T > /Archive/glibc-git/build-system-gcc/shlib.lds > /Archive/glibc-git/build-system-gcc/csu/abi-note.o > /Archive/glibc-git/build-system-gcc/elf/soinit.os > /Archive/glibc-git/build-system-gcc/libc_pic.os > /Archive/glibc-git/build-system-gcc/elf/sofini.os > /Archive/glibc-git/build-system-gcc/elf/interp.os > /Archive/glibc-git/build-system-gcc/elf/ld.so -lgcc > /Archive/glibc-git/build-system-gcc/libc_pic.os: In function > `__libc_ifunc_impl_list': > /Archive/glibc-git/misc/../sysdeps/x86_64/multiarch/ifunc-impl-list.c:50: > undefined reference to `__memmove_chk_avx512_no_vzeroupper' > /usr/bin/ld: /Archive/glibc-git/build-system-gcc/libc_pic.os: > relocation R_X86_64_PC32 against undefined hidden symbol > `__memmove_chk_avx512_no_vzeroupper' can not be used when making a > shared object > /usr/bin/ld: final link failed: Bad value > collect2: error: ld returned 1 exit status > ../Makerules:681: recipe for target > '/Archive/glibc-git/build-system-gcc/libc.so' failed > make[2]: *** [/Archive/glibc-git/build-system-gcc/libc.so] Error 1 > make[2]: Leaving directory '/Archive/glibc-git/elf' > Makefile:214: recipe for target 'elf/subdir_lib' failed > make[1]: *** [elf/subdir_lib] Error 2 > make[1]: Leaving directory '/Archive/glibc-git' > Makefile:9: recipe for target 'all' failed > make: *** [all] Error 2 > > Please try this.
diff --git a/sysdeps/x86_64/multiarch/memcpy_chk.S b/sysdeps/x86_64/multiarch/memcpy_chk.S index a0d56d4..648217e 100644 --- a/sysdeps/x86_64/multiarch/memcpy_chk.S +++ b/sysdeps/x86_64/multiarch/memcpy_chk.S @@ -33,9 +33,9 @@ ENTRY(__memcpy_chk) #ifdef HAVE_AVX512_ASM_SUPPORT HAS_ARCH_FEATURE (AVX512F_Usable) jz 1f -# HAS_ARCH_FEATURE (Prefer_No_VZEROUPPER) -# jz 1f - leaq __memcpy_avx512_no_vzeroupper(%rip), %rax + HAS_ARCH_FEATURE (Prefer_No_VZEROUPPER) + jz 1f + leaq __memcpy_chk_avx512_no_vzeroupper(%rip), %rax ret #endif 1: leaq __memcpy_chk_sse2(%rip), %rax