| Message ID | 002a01d13bd9$29442990$7bcc7cb0$@foss.arm.com |
|---|---|
| State | New, archived |
| Headers |
Received: (qmail 64186 invoked by alias); 21 Dec 2015 10:20:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64078 invoked by uid 89); 21 Dec 2015 10:20:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.7 required=5.0 tests=AWL, BAYES_40, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=sk:owner@s, ownersourcewareorg, sk:owners, owner@sourceware.org X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Dec 2015 10:20:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C2D23A8; Mon, 21 Dec 2015 02:19:39 -0800 (PST) Received: from SHAWIN202 (unknown [10.164.6.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1AB4D3F24D; Mon, 21 Dec 2015 02:20:04 -0800 (PST) From: "Thomas Preud'homme" <thomas.preudhomme@foss.arm.com> To: "'Joel Brobecker'" <brobecker@adacore.com> Cc: <gdb-patches@sourceware.org> References: <000101d13979$d1e0c610$75a25230$@foss.arm.com> <20151218182252.GF29928@adacore.com> In-Reply-To: <20151218182252.GF29928@adacore.com> Subject: RE: [PATCH, ping1] Add missing expect for running a program with CLI jump Date: Mon, 21 Dec 2015 18:20:03 +0800 Message-ID: <002a01d13bd9$29442990$7bcc7cb0$@foss.arm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_002B_01D13C1C.376F0AB0" |
Commit Message
Thomas Preud'homme
Dec. 21, 2015, 10:20 a.m. UTC
Hi Joel, I hope this time it's fine. I'm also adding it in attachment just in case. Best regards, Thomas > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Joel Brobecker > Sent: Saturday, December 19, 2015 2:23 AM > To: Thomas Preud'homme > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH, ping1] Add missing expect for running a program > with CLI jump > > > > 2015-10-15 Thomas Preud'homme > <thomas.preudhomme@arm.com> > > > > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the > CLI > > > jump > > > case. > > I think the patch is good, but your mailer did some line folding. > Can you resend? > > Thanks! > > > > > > > > > > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi- > > > support.exp > > > index 0d17ecb..cc055f6 100644 > > > --- a/gdb/testsuite/lib/mi-support.exp > > > +++ b/gdb/testsuite/lib/mi-support.exp > > > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command > args} { > > > # to better handle RUN. > > > send_gdb "jump *$start\n" > > > warning "Using CLI jump command, expect run-to-main FAIL" > > > + gdb_expect { > > > + -re "${run_match}&\"jump > > > \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa- > > > f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread- > > > id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {} > > > + } > > > return 0 > > > } > > > > > > > > > With this patch applied, testsuite results become much more stable. > > > > > > Is this ok for the master branch? > > > > > > Best regards, > > > > > > Thomas > > > > > > > -- > Joel
Comments
> I hope this time it's fine. I'm also adding it in attachment just in case. > > Best regards, > > Thomas > > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp > index 0d17ecb..cc055f6 100644 > --- a/gdb/testsuite/lib/mi-support.exp > +++ b/gdb/testsuite/lib/mi-support.exp > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} { > # to better handle RUN. > send_gdb "jump *$start\n" > warning "Using CLI jump command, expect run-to-main FAIL" > + gdb_expect { > + -re "${run_match}&\"jump \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {} > + } > return 0 > } Thanks. LGTM, so go ahead and push. > > > > 2015-10-15 Thomas Preud'homme > > <thomas.preudhomme@arm.com> > > > > > > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the > > CLI > > > > jump > > > > case. > > > > I think the patch is good, but your mailer did some line folding. > > Can you resend?
Done, thanks. Best regards, Thomas > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Joel Brobecker > Sent: Monday, December 21, 2015 7:06 PM > To: Thomas Preud'homme > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH, ping1] Add missing expect for running a program > with CLI jump > > > I hope this time it's fine. I'm also adding it in attachment just in case. > > > > Best regards, > > > > Thomas > > > > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi- > support.exp > > index 0d17ecb..cc055f6 100644 > > --- a/gdb/testsuite/lib/mi-support.exp > > +++ b/gdb/testsuite/lib/mi-support.exp > > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} > { > > # to better handle RUN. > > send_gdb "jump *$start\n" > > warning "Using CLI jump command, expect run-to-main FAIL" > > + gdb_expect { > > + -re "${run_match}&\"jump > \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa- > f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread- > id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {} > > + } > > return 0 > > } > > Thanks. LGTM, so go ahead and push. > > > > > > 2015-10-15 Thomas Preud'homme > > > <thomas.preudhomme@arm.com> > > > > > > > > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for > the > > > CLI > > > > > jump > > > > > case. > > > > > > I think the patch is good, but your mailer did some line folding. > > > Can you resend? > -- > Joel
diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp index 0d17ecb..cc055f6 100644 --- a/gdb/testsuite/lib/mi-support.exp +++ b/gdb/testsuite/lib/mi-support.exp @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} { # to better handle RUN. send_gdb "jump *$start\n" warning "Using CLI jump command, expect run-to-main FAIL" + gdb_expect { + -re "${run_match}&\"jump \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {} + } return 0 }