Remove dead code in testsuite
Commit Message
This patch removes cases from the testsuite that are not posssibly used. The
messages "Catch of * not yet implemented" were removed here:
https://www.sourceware.org/ml/gdb-patches/2004-01/msg00679.html
I changed the regexp at the same time to match the string more closely.
gdb/testsuite/ChangeLog:
* gdb.base/break.exp: Remove dead code.
* gdb.base/sepdebug.exp: Likewise.
---
gdb/testsuite/gdb.base/break.exp | 35 ++++++-----------------------------
gdb/testsuite/gdb.base/sepdebug.exp | 37 ++++++-------------------------------
2 files changed, 12 insertions(+), 60 deletions(-)
Comments
On 12/21/2015 06:14 PM, Simon Marchi wrote:
> This patch removes cases from the testsuite that are not posssibly used. The
> messages "Catch of * not yet implemented" were removed here:
>
> https://www.sourceware.org/ml/gdb-patches/2004-01/msg00679.html
>
LGTM.
> I changed the regexp at the same time to match the string more closely.
>
(Could have used $decimal too.)
Thanks,
Pedro Alves
On 15-12-21 01:28 PM, Pedro Alves wrote:
> LGTM.
>
>> I changed the regexp at the same time to match the string more closely.
>>
>
> (Could have used $decimal too.)
>
> Thanks,
> Pedro Alves
>
Thanks, pushed.
@@ -473,37 +473,14 @@ gdb_test "catch" \
"Catch requires an event name." \
"catch requires an event name"
+gdb_test "catch fork" "Catchpoint \[0-9\]+ \\(fork\\)" \
+ "set catch fork, never expected to trigger"
-set name "set catch fork, never expected to trigger"
-gdb_test_multiple "catch fork" "$name" {
- -re "Catchpoint \[0-9\]* .fork..*$gdb_prompt $" {
- pass $name
- }
- -re "Catch of fork not yet implemented.*$gdb_prompt $" {
- pass $name
- }
-}
+gdb_test "catch vfork" "Catchpoint \[0-9\]+ \\(vfork\\)" \
+ "set catch vfork, never expected to trigger"
-
-set name "set catch vfork, never expected to trigger"
-gdb_test_multiple "catch vfork" "$name" {
- -re "Catchpoint \[0-9\]* .vfork..*$gdb_prompt $" {
- pass $name
- }
- -re "Catch of vfork not yet implemented.*$gdb_prompt $" {
- pass $name
- }
-}
-
-set name "set catch exec, never expected to trigger"
-gdb_test_multiple "catch exec" "$name" {
- -re "Catchpoint \[0-9\]* .exec..*$gdb_prompt $" {
- pass $name
- }
- -re "Catch of exec not yet implemented.*$gdb_prompt $" {
- pass $name
- }
-}
+gdb_test "catch exec" "Catchpoint \[0-9\]+ \\(exec\\)" \
+ "set catch exec, never expected to trigger"
# Verify that GDB responds gracefully when asked to set a breakpoint
# on a nonexistent source line.
@@ -283,39 +283,14 @@ if ![runto_main] then { fail "sepdebug tests suppressed" }
gdb_test "catch" "Catch requires an event name.*" \
"catch requires an event name"
-set name "set catch fork, never expected to trigger"
-gdb_test_multiple "catch fork" $name {
- -re "Catchpoint \[0-9\]* .fork.*$gdb_prompt $" {
- pass $name
- }
- -re "Catch of fork not yet implemented.*$gdb_prompt $" {
- pass $name
- }
-}
+gdb_test "catch fork" "Catchpoint \[0-9\]+ \\(fork\\)" \
+ "set catch fork, never expected to trigger"
-# If we are on HP-UX 10.20, we expect an error message to be
-# printed if we type "catch vfork" at the gdb gdb_prompt. This is
-# because on HP-UX 10.20, we cannot catch vfork events.
-
-set name "set catch vfork, never expected to trigger"
-gdb_test_multiple "catch vfork" $name {
- -re "Catchpoint \[0-9\]* .vfork.*$gdb_prompt $" {
- pass $name
- }
- -re "Catch of vfork not yet implemented.*$gdb_prompt $" {
- pass $name
- }
-}
+gdb_test "catch vfork" "Catchpoint \[0-9\]+ \\(vfork\\)" \
+ "set catch vfork, never expected to trigger"
-set name "set catch exec, never expected to trigger"
-gdb_test_multiple "catch exec" $name {
- -re "Catchpoint \[0-9\]* .exec.*$gdb_prompt $" {
- pass $name
- }
- -re "Catch of exec not yet implemented.*$gdb_prompt $" {
- pass $name
- }
-}
+gdb_test "catch exec" "Catchpoint \[0-9\]+ \\(exec\\)" \
+ "set catch exec, never expected to trigger"
# Verify that GDB responds gracefully when asked to set a breakpoint
# on a nonexistent source line.