[6/8] go32-nat.c: Don't override to_open.

Message ID 1395069784-7406-7-git-send-email-palves@redhat.com
State Committed
Headers

Commit Message

Pedro Alves March 17, 2014, 3:23 p.m. UTC
  Although the string says "Done.", nothing is pushing the target as is.
Removing the method override let's us fall through to the the base
to_open implemention in inf-child.c, which will push the target in
reaction to "target native" in a follow up patch.

gdb/
2014-03-17  Pedro Alves  <palves@redhat.com>

	* go32-nat.c (go32_open): Delete.
	(go32_target): Don't override the to_open method.
---
 gdb/go32-nat.c | 7 -------
 1 file changed, 7 deletions(-)
  

Comments

Eli Zaretskii March 17, 2014, 4:44 p.m. UTC | #1
> From: Pedro Alves <palves@redhat.com>
> Date: Mon, 17 Mar 2014 15:23:02 +0000
> 
> Although the string says "Done.", nothing is pushing the target as is.
> Removing the method override let's us fall through to the the base
> to_open implemention in inf-child.c, which will push the target in
> reaction to "target native" in a follow up patch.
> 
> gdb/
> 2014-03-17  Pedro Alves  <palves@redhat.com>
> 
> 	* go32-nat.c (go32_open): Delete.
> 	(go32_target): Don't override the to_open method.

OK.
  

Patch

diff --git a/gdb/go32-nat.c b/gdb/go32-nat.c
index ef5278a..e17707a 100644
--- a/gdb/go32-nat.c
+++ b/gdb/go32-nat.c
@@ -339,12 +339,6 @@  static struct {
 };
 
 static void
-go32_open (char *name, int from_tty)
-{
-  printf_unfiltered ("Done.  Use the \"run\" command to run the program.\n");
-}
-
-static void
 go32_attach (struct target_ops *ops, char *args, int from_tty)
 {
   error (_("\
@@ -960,7 +954,6 @@  go32_target (void)
 {
   struct target_ops *t = inf_child_target ();
 
-  t->to_open = go32_open;
   t->to_attach = go32_attach;
   t->to_resume = go32_resume;
   t->to_wait = go32_wait;