| Message ID | 1398442297-2854-1-git-send-email-will.newton@linaro.org |
|---|---|
| State | Committed |
| Headers |
Return-Path: <x14307373@homiemail-mx23.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id BB24836008E for <siddhesh@wilcox.dreamhost.com>; Fri, 25 Apr 2014 09:11:53 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14307373) id 6BE8D6330FCE2; Fri, 25 Apr 2014 09:11:53 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 45CD06330FCBA for <glibc@patchwork.siddhesh.in>; Fri, 25 Apr 2014 09:11:53 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=pzcZZEd6j3KXZNuIZv2NoGn8ujNknlIudRsZbkAA+wtZXzGRfPbfV P5uCvbnneXc0vPFmV0HRxhEn7Kh2t2a87DXkQ6evic9iXnVs2C2nT+R1ixqFbyZG qIRcNKELIk2ZRelWpbWjc2nbK0HQ7otdpwDXScjZhASVmKLEabYrSM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=A6e5CVilcq1Br+QaxdcMy0nDxOQ=; b=AXzQPcit1IB7QjsnTjigxFwxWxDT E39Sr6tZOUoW7tpixIQ50pbBKFi0K1n2IDDWPS1p8yVJqvbPpjivfrZhOK8GBYAs N23W7mt+UJQWJ/dVHIFqkXkM712JLhG5qo9RPuQiEL9q6rCB+qClHDRI8X1PNmn1 oBgEG+E+Xn6os+I= Received: (qmail 3981 invoked by alias); 25 Apr 2014 16:11:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-glibc=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 3954 invoked by uid 89); 25 Apr 2014 16:11:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f181.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=NfE9xwmm1YEuQWQzsRNmOmHXOS6lVYhfgKVkm1+wVJk=; b=ThMRNOZTetwsiuWjjQEKAficY+WfvRCOJ7UhJSyfNXTMS+cDrB+5OXcEhSGOw7ESb8 GL1UwX/lsFeG1eWSTvdOqAPuuoXb9ELdHFKICfbyOxGdRUc2i1+YgksHbtmk/43roA99 Ag5UVnAcDMEXxYZz8phtfqGWn3nMwkkdjJIZGMz5XAeIJdaeli3FcPCnwmNcFDFXBUc+ DLnCTJ5EdxDPFVNZa3LJyNZ7/fU6Iuw1s9F9tYaGb4q34ekU7CUCdD2xpFexuySZ6DH4 nOwfCiaHNfZeaWtVMThXu7kIrLn6p5EkrlZy8TYHy8CyUHqAgi6MMTmL1TzoxBB0rSdA Ua3w== X-Gm-Message-State: ALoCoQn0SnmZIlWfik+bzXOeJkQek7z341n7jdWV7Sw6LcRmCwuxRV8n02Q9o85JVy/dFkiLDzdz X-Received: by 10.180.21.180 with SMTP id w20mr4422400wie.34.1398442303395; Fri, 25 Apr 2014 09:11:43 -0700 (PDT) From: Will Newton <will.newton@linaro.org> To: libc-alpha@sourceware.org Subject: [PATCH] stdlib/gmp-impl.h: Silence -Wundef warning for USE_STACK_ALLOC Date: Fri, 25 Apr 2014 17:11:37 +0100 Message-Id: <1398442297-2854-1-git-send-email-will.newton@linaro.org> X-DH-Original-To: glibc@patchwork.siddhesh.in |
Commit Message
Will Newton
April 25, 2014, 4:11 p.m. UTC
The upstream version of GMP has long removed this conditional altogether in this commit: changeset: 5254:88618a4694ac user: Kevin Ryde <user42@zip.com.au> date: Sun Jun 17 01:37:27 2001 +0200 So just turn the #if into an #ifdef to silence the warning. ChangeLog: 2014-04-25 Will Newton <will.newton@linaro.org> * stdlib/gmp-impl.h: Test USE_STACK_ALLOC #ifdef rather than #if. --- stdlib/gmp-impl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 25 April 2014 17:11, Will Newton <will.newton@linaro.org> wrote: > The upstream version of GMP has long removed this conditional > altogether in this commit: > > changeset: 5254:88618a4694ac > user: Kevin Ryde <user42@zip.com.au> > date: Sun Jun 17 01:37:27 2001 +0200 > > So just turn the #if into an #ifdef to silence the warning. > > ChangeLog: > > 2014-04-25 Will Newton <will.newton@linaro.org> > > * stdlib/gmp-impl.h: Test USE_STACK_ALLOC #ifdef > rather than #if. > --- > stdlib/gmp-impl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ping? > diff --git a/stdlib/gmp-impl.h b/stdlib/gmp-impl.h > index 83865dc..b7da5bd 100644 > --- a/stdlib/gmp-impl.h > +++ b/stdlib/gmp-impl.h > @@ -47,7 +47,7 @@ along with the GNU MP Library; see the file COPYING.LIB. If not, see > #endif > #endif > > -#if ! defined (HAVE_ALLOCA) || USE_STACK_ALLOC > +#if ! defined (HAVE_ALLOCA) || defined (USE_STACK_ALLOC) > #include "stack-alloc.h" > #else > #define TMP_DECL(m) > -- > 1.9.0 >
On 6 May 2014 10:21, Will Newton <will.newton@linaro.org> wrote: > On 25 April 2014 17:11, Will Newton <will.newton@linaro.org> wrote: >> The upstream version of GMP has long removed this conditional >> altogether in this commit: >> >> changeset: 5254:88618a4694ac >> user: Kevin Ryde <user42@zip.com.au> >> date: Sun Jun 17 01:37:27 2001 +0200 >> >> So just turn the #if into an #ifdef to silence the warning. >> >> ChangeLog: >> >> 2014-04-25 Will Newton <will.newton@linaro.org> >> >> * stdlib/gmp-impl.h: Test USE_STACK_ALLOC #ifdef >> rather than #if. >> --- >> stdlib/gmp-impl.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Ping? Ping? >> diff --git a/stdlib/gmp-impl.h b/stdlib/gmp-impl.h >> index 83865dc..b7da5bd 100644 >> --- a/stdlib/gmp-impl.h >> +++ b/stdlib/gmp-impl.h >> @@ -47,7 +47,7 @@ along with the GNU MP Library; see the file COPYING.LIB. If not, see >> #endif >> #endif >> >> -#if ! defined (HAVE_ALLOCA) || USE_STACK_ALLOC >> +#if ! defined (HAVE_ALLOCA) || defined (USE_STACK_ALLOC) >> #include "stack-alloc.h" >> #else >> #define TMP_DECL(m) >> -- >> 1.9.0 >> > > > > -- > Will Newton > Toolchain Working Group, Linaro
On Tue, May 13, 2014 at 10:17:41AM +0100, Will Newton wrote: > On 6 May 2014 10:21, Will Newton <will.newton@linaro.org> wrote: > > On 25 April 2014 17:11, Will Newton <will.newton@linaro.org> wrote: > >> The upstream version of GMP has long removed this conditional > >> altogether in this commit: > >> > >> changeset: 5254:88618a4694ac > >> user: Kevin Ryde <user42@zip.com.au> > >> date: Sun Jun 17 01:37:27 2001 +0200 > >> > >> So just turn the #if into an #ifdef to silence the warning. > >> > >> ChangeLog: > >> > >> 2014-04-25 Will Newton <will.newton@linaro.org> > >> > >> * stdlib/gmp-impl.h: Test USE_STACK_ALLOC #ifdef > >> rather than #if. > >> --- > >> stdlib/gmp-impl.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Ping? > > Ping? > looks ok.
diff --git a/stdlib/gmp-impl.h b/stdlib/gmp-impl.h index 83865dc..b7da5bd 100644 --- a/stdlib/gmp-impl.h +++ b/stdlib/gmp-impl.h @@ -47,7 +47,7 @@ along with the GNU MP Library; see the file COPYING.LIB. If not, see #endif #endif -#if ! defined (HAVE_ALLOCA) || USE_STACK_ALLOC +#if ! defined (HAVE_ALLOCA) || defined (USE_STACK_ALLOC) #include "stack-alloc.h" #else #define TMP_DECL(m)