Message ID | 001a11384590ece205051b1a23d1@google.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 70445 invoked by alias); 17 Jul 2015 22:59:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 70429 invoked by uid 89); 17 Jul 2015 22:59:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f202.google.com Received: from mail-pd0-f202.google.com (HELO mail-pd0-f202.google.com) (209.85.192.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 17 Jul 2015 22:59:31 +0000 Received: by pdbcj9 with SMTP id cj9so11207747pdb.1 for <gdb-patches@sourceware.org>; Fri, 17 Jul 2015 15:59:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:message-id:date:subject:from:to:cc :content-type; bh=dxTU1Xj8lXrpwmeWWOQLcGQmF2omBMp/3TuEZp2prsU=; b=OTD1x6IKT0m6KrHZy1kyb8lZraU3sFTxcpgfpt1I1PddZ2ABtO00y/bzT+A5MdK/bl 0URS8oxXt+sblRSfe/UQuTKEwqVlRP5oh/iBgEVYBeui4QUdf2rgOsjx4L6ui/9VHe5T exr8wbJEAU5RnUErgqrrMPiCwZHhk1p0Dru0KTaTeKj7SnuT8zXaayzi8IPF7Kfqfrqa FEliYg7MwqCv7KevC1H+iQM3rFTopNucAWpnFfQ6lVNUxiz/yuppVbmpD60HLClNXxMR lD7RAOH9+IDgFiBCHypNmykJo8o0b4hwxKGcr2zNatYIFX179flqt+Sb6vfzXnwpC/NQ NerQ== X-Gm-Message-State: ALoCoQn9P7rIwZghq5ek7kvxdePWoAPaO47khfRaxjsJ/q96XxKBYz0OpFDQtdtUSct4TkpQLE1M MIME-Version: 1.0 X-Received: by 10.66.90.163 with SMTP id bx3mr19109013pab.28.1437173969364; Fri, 17 Jul 2015 15:59:29 -0700 (PDT) Message-ID: <001a11384590ece205051b1a23d1@google.com> Date: Fri, 17 Jul 2015 22:59:29 +0000 Subject: Re: [doc RFA] stabs.texinfo: @include gdb-cfg.texi. From: Doug Evans <dje@google.com> To: sellcey@imgtec.com, Eli Zaretskii <eliz@gnu.org> Cc: gdb-patches <gdb-patches@sourceware.org> Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes X-IsSubscribed: yes |
Commit Message
Doug Evans
July 17, 2015, 10:59 p.m. UTC
Doug Evans writes: > On Fri, Jul 17, 2015 at 3:30 PM, Steve Ellcey <sellcey@imgtec.com> wrote: > > On Thu, 2015-07-16 at 16:30 +0000, Doug Evans wrote: > > > >> 2015-07-16 Doug Evans <dje@google.com> > >> > >> * stabs.texinfo: @include gdb-cfg.texi. > >> > >> diff --git a/gdb/doc/stabs.texinfo b/gdb/doc/stabs.texinfo > >> index 15c4152..c4ea037 100644 > >> --- a/gdb/doc/stabs.texinfo > >> +++ b/gdb/doc/stabs.texinfo > >> @@ -3,6 +3,10 @@ > >> @setchapternewpage odd > >> @settitle STABS > >> > >> +@c man begin INCLUDE > >> +@include gdb-cfg.texi > >> +@c man end > >> + > >> @c @finalout > >> > >> @c This is a dir.info fragment to support semi-automated addition of > > > > This patch breaks my parallel gdb builds (though the bug may be a latent > > one that this change finally causes to trigger). On my machine my > > parallel GDB build dies with: > > > > ./gdb-cfg.texi:16: @include `GDBvn.texi': No such file or directory. > > > > And then later in the log I see: > > > > mv GDBvn.new GDBvn.texi > > > > I think there is a missing dependency in the doc/Makefile.in to say that > > GDBvn.texi needs to be built before gdb-cfg.texi. > > Bleah. > I think we just need to update STABS_DOC_BUILD_INCLUDES > to be like GDB_DOC_BUILD_INCLUDES. > I'll take care of it. > > Thanks for the report. 2015-07-17 Doug Evans <dje@google.com> * Makefile.in (STABS_DOC_BUILD_INCLUDES): Add gdb-cfg.texi, GDBvn.texi.
Comments
On Fri, 2015-07-17 at 22:59 +0000, Doug Evans wrote: > 2015-07-17 Doug Evans <dje@google.com> > > * Makefile.in (STABS_DOC_BUILD_INCLUDES): Add gdb-cfg.texi, GDBvn.texi. > > diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in > index bd30a81..85ed95b 100644 > --- a/gdb/doc/Makefile.in > +++ b/gdb/doc/Makefile.in > @@ -143,7 +143,9 @@ GDB_DOC_FILES = \ > # Stabs manual: All files > STABS_DOC_SOURCE_INCLUDES = \ > $(srcdir)/fdl.texi > -STABS_DOC_BUILD_INCLUDES = > +STABS_DOC_BUILD_INCLUDES = \ > + gdb-cfg.texi \ > + GDBvn.texi > STABS_DOC_FILES = \ > $(srcdir)/stabs.texinfo \ > $(STABS_DOC_SOURCE_INCLUDES) \ Doug, are you waiting for an OK from someone before checking this in? I tested the patch locally and it fixed my build problem but it doesn't look like it has been checked in yet. Steve Ellcey sellcey@imgtec.com
On Mon, Jul 20, 2015 at 10:07 AM, Steve Ellcey <sellcey@imgtec.com> wrote: > On Fri, 2015-07-17 at 22:59 +0000, Doug Evans wrote: > >> 2015-07-17 Doug Evans <dje@google.com> >> >> * Makefile.in (STABS_DOC_BUILD_INCLUDES): Add gdb-cfg.texi, GDBvn.texi. >> >> diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in >> index bd30a81..85ed95b 100644 >> --- a/gdb/doc/Makefile.in >> +++ b/gdb/doc/Makefile.in >> @@ -143,7 +143,9 @@ GDB_DOC_FILES = \ >> # Stabs manual: All files >> STABS_DOC_SOURCE_INCLUDES = \ >> $(srcdir)/fdl.texi >> -STABS_DOC_BUILD_INCLUDES = >> +STABS_DOC_BUILD_INCLUDES = \ >> + gdb-cfg.texi \ >> + GDBvn.texi >> STABS_DOC_FILES = \ >> $(srcdir)/stabs.texinfo \ >> $(STABS_DOC_SOURCE_INCLUDES) \ > > Doug, are you waiting for an OK from someone before checking this in? I > tested the patch locally and it fixed my build problem but it doesn't > look like it has been checked in yet. Hi. I checked it in this morning (to trunk and branch).
On Mon, 2015-07-20 at 10:08 -0700, Doug Evans wrote: > Hi. > > I checked it in this morning (to trunk and branch). Thanks, I must have checked just before you checked it in. Steve Ellcey sellcey@imgtec.com
diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in index bd30a81..85ed95b 100644 --- a/gdb/doc/Makefile.in +++ b/gdb/doc/Makefile.in @@ -143,7 +143,9 @@ GDB_DOC_FILES = \ # Stabs manual: All files STABS_DOC_SOURCE_INCLUDES = \ $(srcdir)/fdl.texi -STABS_DOC_BUILD_INCLUDES = +STABS_DOC_BUILD_INCLUDES = \ + gdb-cfg.texi \ + GDBvn.texi STABS_DOC_FILES = \ $(srcdir)/stabs.texinfo \ $(STABS_DOC_SOURCE_INCLUDES) \