Disable debuginfod in printer tests [BZ #28757]
Checks
Context |
Check |
Description |
dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
dj/TryBot-32bit |
success
|
Build for i686
|
Commit Message
With gdb-11.1-6.fc35.x86_64, I got
FAIL: nptl/test-cond-printers
FAIL: nptl/test-condattr-printers
FAIL: nptl/test-mutex-printers
FAIL: nptl/test-mutexattr-printers
FAIL: nptl/test-rwlock-printers
FAIL: nptl/test-rwlockattr-printers
$ cat nptl/test-condattr-printers.out
Error: Response does not match the expected pattern.
Command: start
Expected pattern: main
Response: Temporary breakpoint 1 at 0x11d5: file test-condattr-printers.c, line 43.
Starting program: /export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/nptl/test-condattr-printers
This GDB supports auto-downloading debuginfo from the following URLs:
https://debuginfod.fedoraproject.org/
Enable debuginfod for this session? (y or [n])
Disable debuginfod to avoid GDB messages. This fixes BZ #28757.
---
scripts/test_printers_common.py | 11 +++++++++++
1 file changed, 11 insertions(+)
Comments
* H. J. Lu via Libc-alpha:
> diff --git a/scripts/test_printers_common.py b/scripts/test_printers_common.py
> index 6406e3bac7..38121697bc 100644
> --- a/scripts/test_printers_common.py
> +++ b/scripts/test_printers_common.py
> @@ -161,6 +161,17 @@ def init_test(test_bin, printer_files, printer_names):
> printer files.
> """
>
> + # Disable debuginfod to avoid GDB messages like:
> + #
> + # This GDB supports auto-downloading debuginfo from the following URLs:
> + # https://debuginfod.fedoraproject.org/
> + # Enable debuginfod for this session? (y or [n])
> + #
> + try:
> + test('set debuginfod enabled off')
> + except Exception:
> + pass
This looks okay, based on the discussion in
<https://bugzilla.redhat.com/show_bug.cgi?id=2026402>. The ignored
exception should make this work on older GDB, too.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
@@ -161,6 +161,17 @@ def init_test(test_bin, printer_files, printer_names):
printer files.
"""
+ # Disable debuginfod to avoid GDB messages like:
+ #
+ # This GDB supports auto-downloading debuginfo from the following URLs:
+ # https://debuginfod.fedoraproject.org/
+ # Enable debuginfod for this session? (y or [n])
+ #
+ try:
+ test('set debuginfod enabled off')
+ except Exception:
+ pass
+
# Load all the pretty printer files. We're assuming these are safe.
for printer_file in printer_files:
test('source {0}'.format(printer_file))