diff mbox series

Add a comment for --enable-initfini-array [BZ #27945]

Message ID 20211108155041.168422-1-hjl.tools@gmail.com
State Committed
Commit cbcd65c8b526555d9b98628338973f91f74002ad
Headers
Series Add a comment for --enable-initfini-array [BZ #27945] |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

H.J. Lu Nov. 8, 2021, 3:50 p.m. UTC 
  Document that --enable-initfini-array is enabled by default in GCC 12,
which can be removed when GCC 12 becomes the minimum requirement.
---
 scripts/build-many-glibcs.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Florian Weimer Nov. 8, 2021, 3:57 p.m. UTC | #1 
* H. J. Lu via Libc-alpha:

> Document that --enable-initfini-array is enabled by default in GCC 12,
> which can be removed when GCC 12 becomes the minimum requirement.
> ---
>  scripts/build-many-glibcs.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index aa27a349b6..61b9854e73 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -1450,7 +1450,9 @@ class Config(object):
>          # checking support.  libcilkrts does not support GNU/Hurd (and
>          # has been removed in GCC 8, so --disable-libcilkrts can be
>          # removed once glibc no longer supports building with older
> -        # GCC versions).
> +        # GCC versions).  --enable-initfini-array is enabled by default
> +        # in GCC 12, which can be removed when GCC 12 becomes the
> +        # minimum requirement.

Looks helpful to me.

Thanks,
Florian
diff mbox series

Patch

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index aa27a349b6..61b9854e73 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -1450,7 +1450,9 @@  class Config(object):
         # checking support.  libcilkrts does not support GNU/Hurd (and
         # has been removed in GCC 8, so --disable-libcilkrts can be
         # removed once glibc no longer supports building with older
-        # GCC versions).
+        # GCC versions).  --enable-initfini-array is enabled by default
+        # in GCC 12, which can be removed when GCC 12 becomes the
+        # minimum requirement.
         cfg_opts = list(self.gcc_cfg)
         cfg_opts += ['--enable-initfini-array']
         cfg_opts += ['--disable-libssp', '--disable-libcilkrts']