diff mbox series

elf: Make global.out depend on reldepmod4.so [BZ #28457]

Message ID 20211015182924.1028229-1-hjl.tools@gmail.com
State Committed
Commit f9b152c83f6b80562bd554e9d188636888909450
Headers
Series elf: Make global.out depend on reldepmod4.so [BZ #28457] |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

H.J. Lu Oct. 15, 2021, 6:29 p.m. UTC 
  The global test is linked with globalmod1.so which dlopens reldepmod4.so.
Make global.out depend on reldepmod4.so.  This fixes BZ #28457.
---
 elf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Weimer Oct. 25, 2021, 1:54 p.m. UTC | #1 
* H. J. Lu via Libc-alpha:

> The global test is linked with globalmod1.so which dlopens reldepmod4.so.
> Make global.out depend on reldepmod4.so.  This fixes BZ #28457.
> ---
>  elf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index bf45d8ee24..b01ace2d5a 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -976,7 +976,7 @@ $(objpfx)tst-rtld-preload.out: tst-rtld-preload.sh $(objpfx)ld.so \
>  $(objpfx)initfirst.out: $(objpfx)firstobj.so
>  
>  $(objpfx)global: $(objpfx)globalmod1.so
> -$(objpfx)global.out: $(objpfx)reldepmod1.so
> +$(objpfx)global.out: $(objpfx)reldepmod1.so $(objpfx)reldepmod4.so
>  
>  $(objpfx)dblload.out: $(objpfx)dblloadmod1.so $(objpfx)dblloadmod2.so

Looks okay.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian
diff mbox series

Patch

diff --git a/elf/Makefile b/elf/Makefile
index bf45d8ee24..b01ace2d5a 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -976,7 +976,7 @@  $(objpfx)tst-rtld-preload.out: tst-rtld-preload.sh $(objpfx)ld.so \
 $(objpfx)initfirst.out: $(objpfx)firstobj.so
 
 $(objpfx)global: $(objpfx)globalmod1.so
-$(objpfx)global.out: $(objpfx)reldepmod1.so
+$(objpfx)global.out: $(objpfx)reldepmod1.so $(objpfx)reldepmod4.so
 
 $(objpfx)dblload.out: $(objpfx)dblloadmod1.so $(objpfx)dblloadmod2.so