diff mbox series

benchtests: Updated json bench-variant attribute

Message ID 20210208075953.48422-1-naohirot@fujitsu.com
State Committed
Commit 7960c5eea936185dfa9aeaad81b28dbfb53521dd
Delegated to: Siddhesh Poyarekar
Headers
Series benchtests: Updated json bench-variant attribute |

Commit Message

Naohiro Tamura Feb. 8, 2021, 7:59 a.m. UTC 
  This patch updates json "bench-variant" attribute of "bench-memset.c"
to "default" so that the script "benchtests/scripts/plot_strings.py"
can generate a file "memset_time_default_linear.png".
Without this patch, the script "benchtests/scripts/plot_strings.py"
generates a file "memset_time__linear.png" which has inconsistent form
with "memcpy_time_default_linear.png" and
"memmove_time_default_linear.png".
---
 benchtests/bench-memset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Siddhesh Poyarekar Feb. 8, 2021, 2:09 p.m. UTC | #1 
On 2/8/21 1:29 PM, Naohiro Tamura wrote:
> This patch updates json "bench-variant" attribute of "bench-memset.c"
> to "default" so that the script "benchtests/scripts/plot_strings.py"
> can generate a file "memset_time_default_linear.png".
> Without this patch, the script "benchtests/scripts/plot_strings.py"
> generates a file "memset_time__linear.png" which has inconsistent form
> with "memcpy_time_default_linear.png" and
> "memmove_time_default_linear.png".

That's nicer, I agree.  Looks good to me, I'll commit it if you don't 
have access.

Siddhesh
Naohiro Tamura Feb. 9, 2021, 12:33 a.m. UTC | #2 
Siddhesh-san,

> -----Original Message-----
> From: Siddhesh Poyarekar <siddhesh@gotplt.org>
> Sent: Monday, February 8, 2021 11:09 PM
> To: Tamura, Naohiro/田村 直広 <naohirot@fujitsu.com>;
> libc-alpha@sourceware.org
> Subject: Re: [PATCH] benchtests: Updated json bench-variant attribute
> 
> On 2/8/21 1:29 PM, Naohiro Tamura wrote:
> > This patch updates json "bench-variant" attribute of "bench-memset.c"
> > to "default" so that the script "benchtests/scripts/plot_strings.py"
> > can generate a file "memset_time_default_linear.png".
> > Without this patch, the script "benchtests/scripts/plot_strings.py"
> > generates a file "memset_time__linear.png" which has inconsistent form
> > with "memcpy_time_default_linear.png" and
> > "memmove_time_default_linear.png".
> 
> That's nicer, I agree.  Looks good to me, I'll commit it if you don't have access.

Thank you for reviewing quickly.
Yes, please, I don't have the access. I appreciate that!

Naohiro

> Siddhesh
diff mbox series

Patch

diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
index a84e781bdb..1174900e88 100644
--- a/benchtests/bench-memset.c
+++ b/benchtests/bench-memset.c
@@ -97,7 +97,7 @@  test_main (void)
 
   json_attr_object_begin (&json_ctx, "functions");
   json_attr_object_begin (&json_ctx, TEST_NAME);
-  json_attr_string (&json_ctx, "bench-variant", "");
+  json_attr_string (&json_ctx, "bench-variant", "default");
 
   json_array_begin (&json_ctx, "ifuncs");
   FOR_EACH_IMPL (impl, 0)