Message ID | 20210203212508.162239-1-alx.manpages@gmail.com |
---|---|
State | Not applicable |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BAC3B3896C28; Wed, 3 Feb 2021 21:25:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BAC3B3896C28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612387553; bh=tGRC8R9D+wpScXKVRPo4HTp3B1dMKeICwMDqRvr54A0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=Jb/5PjJswUz6SZA26la5UH2v/4lqHm/3q4Xrha5XG+M/okaks5AJYUt/9uF8qs5me QhUGyjGty95jat/VWagt/dNf7TjJGmtaS8EcPdVILQOf4+9DZ7+upeG+kT6SoX4R9E KFUlUL165c3AksM712j9MfoxKuBU5wWWlN3wiQh0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 39816384A02A for <libc-alpha@sourceware.org>; Wed, 3 Feb 2021 21:25:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 39816384A02A Received: by mail-wm1-x332.google.com with SMTP id u14so1064466wmq.4 for <libc-alpha@sourceware.org>; Wed, 03 Feb 2021 13:25:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tGRC8R9D+wpScXKVRPo4HTp3B1dMKeICwMDqRvr54A0=; b=Ub+/Ddv8UaalUh85sPtDVn/lZUSY1ERvFtog8Ur+Lw8GXdvVsxj18EMyi5JC4NChwY dN5sWBfxrMNSzKSm9JM1k9CI0LOLP9yhnewA2Vv74M3TmFHN9fLB7Odu53x8Z3wbI20j qLNzJ2IMmMKoHIG3PNiarEzdgBwriXslGIZJokQfs5VGuVKCGJyGuWA691+7TF7VoBWY 9FAGE9HSkSW/Br3cjXr70bNNZSJJ2zhbMH2Ik5SBtssvkCsClnr/kMsy9zh5rZ+0a0di kAIDNkwB9Z03OKGCGdynNf9voR4qSszrIWuJsVvpze6dvt5zJIj/tlGu4Z3k1nVMZM/h ijNw== X-Gm-Message-State: AOAM533hK+xussVSS7uxM02SqLISrWAkl/OoDIp+nUBIjEbKVGMKABsw Tu9T07fsny2Mms+WjAbDfa0= X-Google-Smtp-Source: ABdhPJzimoWvB/UqS2ZM5Rg0VNWOImQ/mB7kmcHUIpDadcC/EARaqoE10UamFrX5M1fRmdtF2vHcCg== X-Received: by 2002:a7b:c04c:: with SMTP id u12mr4674707wmc.185.1612387550398; Wed, 03 Feb 2021 13:25:50 -0800 (PST) Received: from debian.vlc ([170.253.51.130]) by smtp.gmail.com with ESMTPSA id l14sm5507728wrq.87.2021.02.03.13.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 13:25:49 -0800 (PST) To: mtk.manpages@gmail.com Subject: [PATCH] getsockname.2: Use restrict in prototypes Date: Wed, 3 Feb 2021 22:25:09 +0100 Message-Id: <20210203212508.162239-1-alx.manpages@gmail.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Alejandro Colomar via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Alejandro Colomar <alx.manpages@gmail.com> Cc: Alejandro Colomar <alx.manpages@gmail.com>, linux-man@vger.kernel.org, libc-alpha@sourceware.org, Heinrich Schuchardt <xypron.glpk@gmx.de> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
getsockname.2: Use restrict in prototypes
|
|
Commit Message
Alejandro Colomar
Feb. 3, 2021, 9:25 p.m. UTC
POSIX specifies that the 2nd and 3rd parameters to getsockname() shall be 'restrict'. Glibc uses 'restrict' too. Let's use it here too. ...... .../glibc$ grep_syscall_wrapper getsockname socket/sys/socket.h:116: extern int getsockname (int __fd, __SOCKADDR_ARG __addr, socklen_t *__restrict __len) __THROW; .../glibc$ grep -rn '# *define __SOCKADDR_ARG' socket/sys/socket.h:58: # define __SOCKADDR_ARG struct sockaddr *__restrict .../glibc$ function grep_syscall_wrapper() { if ! [ -v 1 ]; then >&2 echo "Usage: ${FUNCNAME[0]} <syscall>"; return ${EX_USAGE}; fi find * -type f \ |grep '\.h$' \ |sort -V \ |xargs pcregrep -Mn \ "(?s)^[^\s#][\w\s]+\s+\**${1}\s*\([\w\s()[\]*,]*?(...)?\)[\w\s()]*;" \ |sed -E 's/^[^:]+:[0-9]+:/&\n/'; } Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> --- man2/getsockname.2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 2/3/21 10:25 PM, Alejandro Colomar wrote: > POSIX specifies that the 2nd and 3rd parameters to getsockname() > shall be 'restrict'. Glibc uses 'restrict' too. > Let's use it here too. > > ...... > > .../glibc$ grep_syscall_wrapper getsockname > socket/sys/socket.h:116: > extern int getsockname (int __fd, __SOCKADDR_ARG __addr, > socklen_t *__restrict __len) __THROW; > .../glibc$ grep -rn '# *define __SOCKADDR_ARG' > socket/sys/socket.h:58: > # define __SOCKADDR_ARG struct sockaddr *__restrict > .../glibc$ > > function grep_syscall_wrapper() > { > if ! [ -v 1 ]; then > >&2 echo "Usage: ${FUNCNAME[0]} <syscall>"; > return ${EX_USAGE}; > fi > > find * -type f \ > |grep '\.h$' \ > |sort -V \ > |xargs pcregrep -Mn \ > "(?s)^[^\s#][\w\s]+\s+\**${1}\s*\([\w\s()[\]*,]*?(...)?\)[\w\s()]*;" \ > |sed -E 's/^[^:]+:[0-9]+:/&\n/'; > } > > Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> Hi Michael, I forgot to actually add restrict to one of the parameters. Wait for v2 :) Cheers, Alex > --- > man2/getsockname.2 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/man2/getsockname.2 b/man2/getsockname.2 > index 55db4b84c..034c9d4ac 100644 > --- a/man2/getsockname.2 > +++ b/man2/getsockname.2 > @@ -44,8 +44,8 @@ getsockname \- get socket name > .nf > .B #include <sys/socket.h> > .PP > -.BI "int getsockname(int " sockfd ", struct sockaddr *" addr \ > -", socklen_t *" addrlen ); > +.BI "int getsockname(int " sockfd ", struct sockaddr *" addr , > +.BI " socklen_t *restrict " addrlen ); > .fi > .SH DESCRIPTION > .BR getsockname () >
diff --git a/man2/getsockname.2 b/man2/getsockname.2 index 55db4b84c..034c9d4ac 100644 --- a/man2/getsockname.2 +++ b/man2/getsockname.2 @@ -44,8 +44,8 @@ getsockname \- get socket name .nf .B #include <sys/socket.h> .PP -.BI "int getsockname(int " sockfd ", struct sockaddr *" addr \ -", socklen_t *" addrlen ); +.BI "int getsockname(int " sockfd ", struct sockaddr *" addr , +.BI " socklen_t *restrict " addrlen ); .fi .SH DESCRIPTION .BR getsockname ()