Message ID | 20201207145520.745916-1-hjl.tools@gmail.com |
---|---|
State | Dropped |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F5683943548; Mon, 7 Dec 2020 14:55:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F5683943548 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607352929; bh=4AV7P58/upne/+NaNF2ekEM5sDH8dwVrkp6VAmhrGU0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Tpvtw8IiBF46BXWTIjekzizy4lFIAAmIyAcX4oIq6DmEw7XdvJ0lufV+HybaBqk9l 9CoP0LhwHqYWG7yG3/ngoDhPos7OgcD55Qdl7yHRqsbtMYdmHPUSyc+B+1BvMAlQvb 1uq7eBZZbf96zzkKQ1bFR1zulXUP+TYqQsCr+Jaw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 8E879385783D for <libc-alpha@sourceware.org>; Mon, 7 Dec 2020 14:55:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8E879385783D Received: by mail-pg1-x535.google.com with SMTP id 69so1230983pgg.8 for <libc-alpha@sourceware.org>; Mon, 07 Dec 2020 06:55:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=4AV7P58/upne/+NaNF2ekEM5sDH8dwVrkp6VAmhrGU0=; b=AuH6xrNbWLS2uer2cFJLjD57LSDUpurXD3+xXavzCeoDAMl1UvaaJRPmst7iyvRykw EDuOlkuIn7YbMdlA2/KFoa1wfHIupjzNJ9FZ/0/7S3zH1vfiAjEpE2zfu/emN9G2I80j FZytdjx+WVLqIcEl4LMe9EdKL2PGOHdw8AWy6BSEu8ihpkfNYnJ3zSVWcB5BF5yqz6mc /rn+3bt/aIWFlmGdY3KvRsz7CLQjDQuSu2GZMSPkVeFe/OW72knl0L9LxeSv8OI1Vn1g 55jyfje1BHUNOTWnOC0vhWyRTQFSOHJ+OUIWZ2+0EV+LIAVSwug8g2WpjNIFLDtjNLqv pXOw== X-Gm-Message-State: AOAM533LEexAWs1uxXbUaG2dp58SKpsdZiagFdKi1MKgIcSDhh4adFCL 4fHHSjhkDFTmwSorJPo9W3bmS87E9hA= X-Google-Smtp-Source: ABdhPJwy18NsT7oAX9tG2J7FcYy+uc1lJZk0QgfbJKFZG3mcmMg4Xmd4zpjAeAM0CIkFl/qyb+KgoA== X-Received: by 2002:a63:471f:: with SMTP id u31mr18576384pga.74.1607352924364; Mon, 07 Dec 2020 06:55:24 -0800 (PST) Received: from gnu-cfl-2.localdomain (c-69-181-90-243.hsd1.ca.comcast.net. [69.181.90.243]) by smtp.gmail.com with ESMTPSA id 84sm1267378pfy.9.2020.12.07.06.55.23 for <libc-alpha@sourceware.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 06:55:23 -0800 (PST) Received: from gnu-cfl-2.localdomain (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id A12C71A0174 for <libc-alpha@sourceware.org>; Mon, 7 Dec 2020 06:55:22 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH] Enable tst-glibc-hwcaps-cache for --enable-hardcoded-path-in-tests Date: Mon, 7 Dec 2020 06:55:20 -0800 Message-Id: <20201207145520.745916-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3040.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org> Reply-To: "H.J. Lu" <hjl.tools@gmail.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
Enable tst-glibc-hwcaps-cache for --enable-hardcoded-path-in-tests
|
|
Commit Message
H.J. Lu
Dec. 7, 2020, 2:55 p.m. UTC
RPATH/RUNPATH works with glibc-hwcaps for this test. --- sysdeps/x86_64/Makefile | 4 ---- 1 file changed, 4 deletions(-)
Comments
* H. J. Lu via Libc-alpha:
> RPATH/RUNPATH works with glibc-hwcaps for this test.
I find that surprising. I thought that $(objpfx)/elf would be on the
search path and searched first, so that the detection logic would not
work.
Or isn't $(objpfx)/elf copied into the testroot with all its files?
Cc:ing DJ.
Thanks,
Florian
On Mon, Dec 7, 2020 at 7:43 AM Florian Weimer <fweimer@redhat.com> wrote: > > * H. J. Lu via Libc-alpha: > > > RPATH/RUNPATH works with glibc-hwcaps for this test. > > I find that surprising. I thought that $(objpfx)/elf would be on the > search path and searched first, so that the detection logic would not > work. > > Or isn't $(objpfx)/elf copied into the testroot with all its files? [hjl@gnu-cfl-2 testroot.pristine]$ pwd /export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/testroot.pristine [hjl@gnu-cfl-2 testroot.pristine]$ find export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux -type f export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/elf/ld-linux-x86-64.so.2 export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/math/libm.so.6 export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/libc.so.6 [hjl@gnu-cfl-2 testroot.pristine]$ ld.so, libc.so and libm.so are copied. Since [hjl@gnu-cfl-2 build-x86_64-linux]$ readelf -dl elf/tst-glibc-hwcaps-cache Elf file type is EXEC (Executable file) Entry point 0x4011d0 There are 13 program headers, starting at offset 64 Program Headers: Type Offset VirtAddr PhysAddr FileSiz MemSiz Flags Align PHDR 0x0000000000000040 0x0000000000400040 0x0000000000400040 0x00000000000002d8 0x00000000000002d8 R 0x8 INTERP 0x0000000000000318 0x0000000000400318 0x0000000000400318 0x0000000000000048 0x0000000000000048 R 0x1 [Requesting program interpreter: /export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/elf/ld.so] LOAD 0x0000000000000000 0x0000000000400000 0x0000000000400000 0x0000000000000b28 0x0000000000000b28 R 0x1000 LOAD 0x0000000000001000 0x0000000000401000 0x0000000000401000 0x00000000000006bd 0x00000000000006bd R E 0x1000 LOAD 0x0000000000002000 0x0000000000402000 0x0000000000402000 0x0000000000000510 0x0000000000000510 R 0x1000 LOAD 0x0000000000002de8 0x0000000000403de8 0x0000000000403de8 0x00000000000002a8 0x00000000000002b8 RW 0x1000 DYNAMIC 0x0000000000002e00 0x0000000000403e00 0x0000000000403e00 0x00000000000001f0 0x00000000000001f0 RW 0x8 NOTE 0x0000000000000360 0x0000000000400360 0x0000000000400360 0x0000000000000030 0x0000000000000030 R 0x8 NOTE 0x0000000000000390 0x0000000000400390 0x0000000000400390 0x0000000000000044 0x0000000000000044 R 0x4 GNU_PROPERTY 0x0000000000000360 0x0000000000400360 0x0000000000400360 0x0000000000000030 0x0000000000000030 R 0x8 GNU_EH_FRAME 0x0000000000002250 0x0000000000402250 0x0000000000402250 0x000000000000007c 0x000000000000007c R 0x4 GNU_STACK 0x0000000000000000 0x0000000000000000 0x0000000000000000 0x0000000000000000 0x0000000000000000 RW 0x10 GNU_RELRO 0x0000000000002de8 0x0000000000403de8 0x0000000000403de8 0x0000000000000218 0x0000000000000218 R 0x1 Section to Segment mapping: Segment Sections... 00 01 .interp 02 .interp .note.gnu.property .note.gnu.build-id .note.ABI-tag .hash .gnu.hash .dynsym .dynstr .gnu.version .gnu.version_r .rela.dyn .rela.plt 03 .init .plt .text .fini 04 .rodata .eh_frame_hdr .eh_frame 05 .init_array .fini_array .dynamic .got .got.plt .data .bss 06 .dynamic 07 .note.gnu.property 08 .note.gnu.build-id .note.ABI-tag 09 .note.gnu.property 10 .eh_frame_hdr 11 12 .init_array .fini_array .dynamic .got Dynamic section at offset 0x2e00 contains 26 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000f (RPATH) Library rpath: [/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/math:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/elf:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/dlfcn:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/nss:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/nis:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/rt:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/resolv:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/mathvec:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/support:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/crypt:/export/build/gnu/tools-build/glibc-gitlab/build-x86_64-linux/nptl] it works fine. > Cc:ing DJ.
diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile index d1d7cb9d2e..7dc04972b8 100644 --- a/sysdeps/x86_64/Makefile +++ b/sysdeps/x86_64/Makefile @@ -177,11 +177,7 @@ $(objpfx)glibc-hwcaps/x86-64-v4/libmarkermod4.so: $(objpfx)libmarkermod4-4.so $(make-target-directory) cp $< $@ -ifeq (no,$(build-hardcoded-path-in-tests)) -# This is an ld.so.cache test, and RPATH/RUNPATH in the executable -# interferes with its test objectives. tests-container += tst-glibc-hwcaps-cache -endif endif # $(subdir) == elf