Message ID | 20200828165513.25649-1-mjw@redhat.com |
---|---|
State | Committed |
Commit | 721a853415e358ba887c9fc693899cb648ca79f3 |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 80F2D39484B0; Fri, 28 Aug 2020 16:55:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 80F2D39484B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1598633732; bh=T9szflfNfDb48M34XBJjO1lypenW+BxB9h9t0JOSyqM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=NvuGJ7MT/b0yCnzZuEHMdVOn59xwhEh4q80hW+K7Uxc2nDYN2SkZsyJv9QOjNV1KZ Fk40uAIFhUobe+NjOITtEhDY/DQ5rsyBWRWQraLz6VCLIwhTRuxCqseFeLX7QrgpnR 2zClyiKOhTEI9xcyxhnzMbF4YOy7Q7csvT5Nm8fE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id E04303861031 for <libc-alpha@sourceware.org>; Fri, 28 Aug 2020 16:55:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E04303861031 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-0RVKte64P12V6006Gwh5gQ-1; Fri, 28 Aug 2020 12:55:26 -0400 X-MC-Unique: 0RVKte64P12V6006Gwh5gQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B501186F2EC; Fri, 28 Aug 2020 16:55:25 +0000 (UTC) Received: from tarox.wildebeest.org (ovpn-112-53.ams2.redhat.com [10.36.112.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2152460BA7; Fri, 28 Aug 2020 16:55:25 +0000 (UTC) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id C78C34028EA8; Fri, 28 Aug 2020 18:55:23 +0200 (CEST) To: libc-alpha@sourceware.org Subject: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants Date: Fri, 28 Aug 2020 18:55:13 +0200 Message-Id: <20200828165513.25649-1-mjw@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Mark Wielaard via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Mark Wielaard <mjw@redhat.com> Cc: Mark Wielaard <mark@klomp.org> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
elf.h: Add aarch64 bti/pac dynamic tag constants
|
|
Commit Message
Mark Wielaard
Aug. 28, 2020, 4:55 p.m. UTC
From: Mark Wielaard <mark@klomp.org>
Constants double checked against binutils and the ELF for the Arm 64-bit
Architecture (AArch64) Release 2020Q2 document.
---
elf/elf.h | 2 ++
1 file changed, 2 insertions(+)
Comments
* Mark Wielaard via Libc-alpha: > From: Mark Wielaard <mark@klomp.org> > > Constants double checked against binutils and the ELF for the Arm 64-bit > Architecture (AArch64) Release 2020Q2 document. > --- > elf/elf.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/elf/elf.h b/elf/elf.h > index 197b557d15..ff9f1dadd5 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -2875,6 +2875,8 @@ enum > #define R_AARCH64_IRELATIVE 1032 /* STT_GNU_IFUNC relocation. */ > > /* AArch64 specific values for the Dyn d_tag field. */ > +#define DT_AARCH64_BTI_PLT (DT_LOPROC + 1) > +#define DT_AARCH64_PAC_PLT (DT_LOPROC + 3) > #define DT_AARCH64_VARIANT_PCS (DT_LOPROC + 5) > #define DT_AARCH64_NUM 6 I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned that in the commit message? There's no PAC PLT with glibc, and people are expected to use BIND_NOW. (I hope I remember this correctly.) Thanks, Florian
Hi Florian, On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote: > I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned that > in the commit message? There's no PAC PLT with glibc, and people are > expected to use BIND_NOW. OK, how about with the attached commit message? Thanks, Mark
* Mark Wielaard: > Hi Florian, > > On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote: >> I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned that >> in the commit message? There's no PAC PLT with glibc, and people are >> expected to use BIND_NOW. > > OK, how about with the attached commit message? Yes, this is what I had in mind, but please wait for an ack from an AArch64 maintainer. Thanks, Florian
On Fri, 2020-08-28 at 21:04 +0200, Florian Weimer wrote: > * Mark Wielaard: > > On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote: > > > I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned > > > that > > > in the commit message? There's no PAC PLT with glibc, and people > > > are > > > expected to use BIND_NOW. > > > > OK, how about with the attached commit message? > > Yes, this is what I had in mind, but please wait for an ack from an > AArch64 maintainer. OK. Ping. Any AArch64 maintainer want to ack or nack this commit? Thanks, Mark
* Mark Wielaard <mark@klomp.org> [2020-09-02 13:28:02 +0200]: > On Fri, 2020-08-28 at 21:04 +0200, Florian Weimer wrote: > > * Mark Wielaard: > > > On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote: > > > > I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned > > > > that > > > > in the commit message? There's no PAC PLT with glibc, and people > > > > are > > > > expected to use BIND_NOW. > > > > > > OK, how about with the attached commit message? > > > > Yes, this is what I had in mind, but please wait for an ack from an > > AArch64 maintainer. > > OK. Ping. Any AArch64 maintainer want to ack or nack this commit? i'm on a long holiday, i will be back on sept 21. the patch looks good, but i wont use my @arm.com email until i'm back. > > Thanks, > > Mark > From 3b925f004607cebc167af907c053bd7ef7146a3b Mon Sep 17 00:00:00 2001 > From: Mark Wielaard <mark@klomp.org> > Date: Fri, 28 Aug 2020 18:44:16 +0200 > Subject: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants > > Constants double checked against binutils and the ELF for the Arm 64-bit > Architecture (AArch64) Release 2020Q2 document. > > Only BTI PLT is used in glibc, there's no PAC PLT with glibc, and people > are expected to use BIND_NOW. > --- > elf/elf.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/elf/elf.h b/elf/elf.h > index 197b557d15..ff9f1dadd5 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -2875,6 +2875,8 @@ enum > #define R_AARCH64_IRELATIVE 1032 /* STT_GNU_IFUNC relocation. */ > > /* AArch64 specific values for the Dyn d_tag field. */ > +#define DT_AARCH64_BTI_PLT (DT_LOPROC + 1) > +#define DT_AARCH64_PAC_PLT (DT_LOPROC + 3) > #define DT_AARCH64_VARIANT_PCS (DT_LOPROC + 5) > #define DT_AARCH64_NUM 6 > > -- > 2.18.4 >
On Sun, 2020-09-06 at 22:21 +0200, Szabolcs Nagy wrote: > * Mark Wielaard <mark@klomp.org> [2020-09-02 13:28:02 +0200]: > > On Fri, 2020-08-28 at 21:04 +0200, Florian Weimer wrote: > > > * Mark Wielaard: > > > > On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote: > > > > > I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned > > > > > that in the commit message? There's no PAC PLT with glibc, and > > > > > people are expected to use BIND_NOW. > > > > > > > > OK, how about with the attached commit message? > > > > > > Yes, this is what I had in mind, but please wait for an ack from an > > > AArch64 maintainer. > > > > OK. Ping. Any AArch64 maintainer want to ack or nack this commit? > > i'm on a long holiday, i will be back on sept 21. > > the patch looks good Thanks pushed. Have a nice holiday. Cheers, Mark
diff --git a/elf/elf.h b/elf/elf.h index 197b557d15..ff9f1dadd5 100644 --- a/elf/elf.h +++ b/elf/elf.h @@ -2875,6 +2875,8 @@ enum #define R_AARCH64_IRELATIVE 1032 /* STT_GNU_IFUNC relocation. */ /* AArch64 specific values for the Dyn d_tag field. */ +#define DT_AARCH64_BTI_PLT (DT_LOPROC + 1) +#define DT_AARCH64_PAC_PLT (DT_LOPROC + 3) #define DT_AARCH64_VARIANT_PCS (DT_LOPROC + 5) #define DT_AARCH64_NUM 6