Message ID | alpine.LFD.2.21.2007090520150.24175@redsun52.ssa.fujisawa.hgst.com |
---|---|
State | Committed |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7A1E3858D35; Thu, 9 Jul 2020 04:40:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7A1E3858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1594269634; bh=/dS+22Ls0qbsk9j6Jq7fQCqaq8B1vTG9xFW4jEjINBE=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=lIo+AAC6Fa45/b25jMXVfb0X/G/LZIEZjpFjCgYV7y5i6iWJ7TmZeTPNL/ptYA3HE E3rqMrOrSYW1hGcrlIIhMIVo8/4V5q2o2Rocu/VtejLSWwgrqAfycOliNDh6xIOlD3 DmdqTHgYFGeMexIcL4EGsyxIyowT/oBaqKLHCmfs= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by sourceware.org (Postfix) with ESMTPS id AC8BD3858D35 for <libc-alpha@sourceware.org>; Thu, 9 Jul 2020 04:40:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AC8BD3858D35 IronPort-SDR: wbqt7EkA6PLVteU1r7DYsKs6Wypt9OGbkw+6Owykog84wmH+TXaL/F4/+rAjvoj0EtCYuCUDtp k5Z2p8x7QqDOEUiJxy763s8oqTX/llg7T5WMHUsrdbY9QiyQteQ5dClDphjDBOVKHl5/whAU/B 7pDHbi57/Y1ofbMsINtNJJdW92vn3a6u3g0FDzFcuH/028rwEAqGX9PWOB/rFO6Gkh7o6ZaM9I Sfl8FpYomxvNtfypf1cQnZ3Hx80BZ2rtSzqs8/uM/uZYSLCvqOCSDNJpImaEuW5QBFi2RLIkF2 q6E= X-IronPort-AV: E=Sophos;i="5.75,330,1589212800"; d="scan'208";a="245009523" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 09 Jul 2020 12:40:45 +0800 IronPort-SDR: okFXPOnetlyPUXJKH878SPPFyYk3D29+ou73fOVen8AQPfOYrIFMSwT7sNVXKEZDrOdiWkIUjW Z9plGK6jUCFgBZm+HAUwGw0OrX5qCxxOo= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 21:28:33 -0700 IronPort-SDR: 7vWEuSVr+i2snqyc+OkgmzXyFb7edMDmU8PrgSXyEF+nLZQHy8IBeFcVU+zrK2KBrbZ1nrY/Sm auagfVOUWYCg== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 21:40:29 -0700 Date: Thu, 9 Jul 2020 05:40:25 +0100 (BST) To: libc-alpha@sourceware.org Subject: [PATCH] linux: Fix syscall list generation instructions Message-ID: <alpine.LFD.2.21.2007090520150.24175@redsun52.ssa.fujisawa.hgst.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: "Maciej W. Rozycki via Libc-alpha" <libc-alpha@sourceware.org> Reply-To: "Maciej W. Rozycki" <macro@wdc.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
linux: Fix syscall list generation instructions
|
|
Commit Message
Maciej W. Rozycki
July 9, 2020, 4:40 a.m. UTC
Make the instructions for syscall list generation match Makefile and refer to `update-syscall-lists'; there has been no `update-arch-syscall' target. Also use single quotes around the command to stick to the ASCII character set. Fixes 4cf0d223052d ("Linux: Add tables with system call numbers"). --- As a fix to a Makefile comment only I trust it is fine to apply even in the freeze period. OK to push then? Maciej --- sysdeps/unix/sysv/linux/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) glibc-update-syscall-lists.diff
Comments
On Wed, Jul 8, 2020 at 9:40 PM Maciej W. Rozycki via Libc-alpha <libc-alpha@sourceware.org> wrote: > > Make the instructions for syscall list generation match Makefile and > refer to `update-syscall-lists'; there has been no `update-arch-syscall' > target. Also use single quotes around the command to stick to the ASCII > character set. > > Fixes 4cf0d223052d ("Linux: Add tables with system call numbers"). Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > As a fix to a Makefile comment only I trust it is fine to apply even in > the freeze period. OK to push then? > > Maciej > --- > sysdeps/unix/sysv/linux/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > glibc-update-syscall-lists.diff > Index: glibc/sysdeps/unix/sysv/linux/Makefile > =================================================================== > --- glibc.orig/sysdeps/unix/sysv/linux/Makefile > +++ glibc/sysdeps/unix/sysv/linux/Makefile > @@ -26,7 +26,7 @@ ifndef subdir > # architecture-specific system call names. > # > # To bootstrap a new architecture, create an empty file in the right > -# place and run ?make update-arch-syscall? from the top-level of a > +# place and run `make update-syscall-lists' from the top-level of a > # configured, but not-yet-built glibc tree. > # > # --lock points to a file not replaced during the update operation, so
On 7/9/20 12:40 AM, Maciej W. Rozycki wrote: > Make the instructions for syscall list generation match Makefile and > refer to `update-syscall-lists'; there has been no `update-arch-syscall' > target. Also use single quotes around the command to stick to the ASCII > character set. > > Fixes 4cf0d223052d ("Linux: Add tables with system call numbers"). > --- > As a fix to a Makefile comment only I trust it is fine to apply even in > the freeze period. OK to push then? > > Maciej > --- > sysdeps/unix/sysv/linux/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > glibc-update-syscall-lists.diff > Index: glibc/sysdeps/unix/sysv/linux/Makefile > =================================================================== > --- glibc.orig/sysdeps/unix/sysv/linux/Makefile > +++ glibc/sysdeps/unix/sysv/linux/Makefile > @@ -26,7 +26,7 @@ ifndef subdir > # architecture-specific system call names. > # > # To bootstrap a new architecture, create an empty file in the right > -# place and run ?make update-arch-syscall? from the top-level of a > +# place and run `make update-syscall-lists' from the top-level of a > # configured, but not-yet-built glibc tree. > # > # --lock points to a file not replaced during the update operation, so > This is trivial and Allistair gave a reivew. Please commit if you haven't already.
On Thu, 9 Jul 2020, Carlos O'Donell wrote: > > Index: glibc/sysdeps/unix/sysv/linux/Makefile > > =================================================================== > > --- glibc.orig/sysdeps/unix/sysv/linux/Makefile > > +++ glibc/sysdeps/unix/sysv/linux/Makefile > > @@ -26,7 +26,7 @@ ifndef subdir > > # architecture-specific system call names. > > # > > # To bootstrap a new architecture, create an empty file in the right > > -# place and run ?make update-arch-syscall? from the top-level of a > > +# place and run `make update-syscall-lists' from the top-level of a > > # configured, but not-yet-built glibc tree. > > # > > # --lock points to a file not replaced during the update operation, so > > > > This is trivial and Allistair gave a reivew. Please commit if you haven't > already. Applied now; thank you both for the go-ahead! Maciej
Index: glibc/sysdeps/unix/sysv/linux/Makefile =================================================================== --- glibc.orig/sysdeps/unix/sysv/linux/Makefile +++ glibc/sysdeps/unix/sysv/linux/Makefile @@ -26,7 +26,7 @@ ifndef subdir # architecture-specific system call names. # # To bootstrap a new architecture, create an empty file in the right -# place and run ?make update-arch-syscall? from the top-level of a +# place and run `make update-syscall-lists' from the top-level of a # configured, but not-yet-built glibc tree. # # --lock points to a file not replaced during the update operation, so