Remove STATFS_IS_STATFS64 conditional as it is zero in all ports
Commit Message
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
sysdeps/unix/sysv/linux/alpha/kernel_stat.h | 1 -
sysdeps/unix/sysv/linux/fstatfs64.c | 14 --------------
sysdeps/unix/sysv/linux/generic/kernel_stat.h | 2 --
.../unix/sysv/linux/generic/wordsize-32/fstatfs.c | 2 --
.../unix/sysv/linux/generic/wordsize-32/statfs.c | 2 --
sysdeps/unix/sysv/linux/hppa/kernel_stat.h | 1 -
sysdeps/unix/sysv/linux/ia64/kernel_stat.h | 1 -
sysdeps/unix/sysv/linux/kernel_stat.h | 1 -
sysdeps/unix/sysv/linux/microblaze/kernel_stat.h | 1 -
sysdeps/unix/sysv/linux/mips/kernel_stat.h | 1 -
.../sysv/linux/powerpc/powerpc32/kernel_stat.h | 1 -
.../sysv/linux/powerpc/powerpc64/kernel_stat.h | 1 -
.../unix/sysv/linux/s390/s390-64/kernel_stat.h | 1 -
.../unix/sysv/linux/sparc/sparc32/kernel_stat.h | 1 -
.../unix/sysv/linux/sparc/sparc64/kernel_stat.h | 1 -
sysdeps/unix/sysv/linux/statfs64.c | 15 ---------------
sysdeps/unix/sysv/linux/x86_64/kernel_stat.h | 1 -
17 files changed, 47 deletions(-)
Comments
I think STATFS_IS_STATFS64 should actually be set to 1 on all 64-bit
architectures execpt alpha?
Andreas.
On 2/19/20 12:51 AM, Andreas Schwab wrote:
> I think STATFS_IS_STATFS64 should actually be set to 1 on all 64-bit
> architectures execpt alpha?
So I experimented with making it 1 on a few 64-bit arches (s390x, powerpc64) but
don't see any cogen changes compared to master for those 2 atleast.
---------->8-----------
diff --git a/sysdeps/unix/sysv/linux/generic/kernel_stat.h
b/sysdeps/unix/sysv/linux/generic/kernel_stat.h
index 2eed3596c0ed..0587e142cf6e 100644
--- a/sysdeps/unix/sysv/linux/generic/kernel_stat.h
+++ b/sysdeps/unix/sysv/linux/generic/kernel_stat.h
@@ -23,8 +23,9 @@
/* We provide separate 32-bit API versions that check for EOVERFLOW. */
#if __WORDSIZE == 64
# define XSTAT_IS_XSTAT64 1
+#define STATFS_IS_STATFS64 1
#else
# define XSTAT_IS_XSTAT64 0
+#define STATFS_IS_STATFS64 0
#endif
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h
b/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h
index 5c10da3356f2..dd970ba69a7c 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h
@@ -18,4 +18,4 @@
#define STAT_IS_KERNEL_STAT 1
#define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0
+#define STATFS_IS_STATFS64 1
diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h
b/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h
index b38bf741d37b..ac580001f01b 100644
--- a/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h
+++ b/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h
@@ -18,4 +18,4 @@
#define STAT_IS_KERNEL_STAT 1
#define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0
+#define STATFS_IS_STATFS64 1
---------->8-----------
And at any rate, no architecture for any ABI defines it to 1 today, it all seems
dead code to me.
Thx,
-Vineet
@@ -86,4 +86,3 @@ struct glibc21_stat
};
#define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0
@@ -22,15 +22,6 @@
#include <sysdep.h>
#include <kernel_stat.h>
-/* Hide the prototypes for __fstatfs and fstatfs so that GCC will not
- complain about the different function signatures if they are aliased
- to __fstat64. If STATFS_IS_STATFS64 is not zero then the statfs and
- statfs64 structures have an identical layout but different type names. */
-
-#if STATFS_IS_STATFS64
-# define __fstatfs __fstatfs_disable
-# define fstatfs fstatfs_disable
-#endif
#include <sys/statfs.h>
#include <kernel-features.h>
@@ -85,8 +76,3 @@ weak_alias (__fstatfs64, fstatfs64)
#undef __fstatfs
#undef fstatfs
-
-#if STATFS_IS_STATFS64
-weak_alias (__fstatfs64, __fstatfs)
-weak_alias (__fstatfs64, fstatfs)
-#endif
@@ -26,5 +26,3 @@
#else
# define XSTAT_IS_XSTAT64 0
#endif
-
-#define STATFS_IS_STATFS64 0
@@ -21,7 +21,6 @@
#include <kernel_stat.h>
#include <stddef.h>
-#if !STATFS_IS_STATFS64
#include "overflow.h"
/* Return information about the filesystem on which FD resides. */
@@ -32,4 +31,3 @@ __fstatfs (int fd, struct statfs *buf)
return rc ?: statfs_overflow (buf);
}
weak_alias (__fstatfs, fstatfs)
-#endif
@@ -21,7 +21,6 @@
#include <kernel_stat.h>
#include <stddef.h>
-#if !STATFS_IS_STATFS64
#include "overflow.h"
/* Return information about the filesystem on which FILE resides. */
@@ -33,4 +32,3 @@ __statfs (const char *file, struct statfs *buf)
}
libc_hidden_def (__statfs)
weak_alias (__statfs, statfs)
-#endif
@@ -31,4 +31,3 @@ struct kernel_stat {
#define _HAVE_STAT64_NSEC
#define XSTAT_IS_XSTAT64 0
-#define STATFS_IS_STATFS64 0
@@ -18,4 +18,3 @@
#define STAT_IS_KERNEL_STAT 1
#define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0
@@ -35,4 +35,3 @@ struct kernel_stat
#define _HAVE_STAT64_NSEC
#define XSTAT_IS_XSTAT64 0
-#define STATFS_IS_STATFS64 0
@@ -49,4 +49,3 @@ struct kernel_stat
};
#define XSTAT_IS_XSTAT64 0
-#define STATFS_IS_STATFS64 0
@@ -57,4 +57,3 @@ struct kernel_stat
#endif
#define XSTAT_IS_XSTAT64 0
-#define STATFS_IS_STATFS64 0
@@ -48,4 +48,3 @@ struct kernel_stat
#define _HAVE_STAT64_NSEC
#define XSTAT_IS_XSTAT64 0
-#define STATFS_IS_STATFS64 0
@@ -18,4 +18,3 @@
#define STAT_IS_KERNEL_STAT 1
#define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0
@@ -18,4 +18,3 @@
#define STAT_IS_KERNEL_STAT 1
#define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0
@@ -32,4 +32,3 @@ struct kernel_stat
#define _HAVE_STAT64_NSEC
#define XSTAT_IS_XSTAT64 0
-#define STATFS_IS_STATFS64 0
@@ -45,4 +45,3 @@ struct kernel_stat64
};
#define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0
@@ -22,15 +22,6 @@
#include <sysdep.h>
#include <kernel_stat.h>
-/* Hide the prototypes for __statfs and statfs so that GCC will not
- complain about the different function signatures if they are aliased
- to __stat64. If STATFS_IS_STATFS64 is not zero then the statfs and
- statfs64 structures have an identical layout but different type names. */
-
-#if STATFS_IS_STATFS64
-# define __statfs __statfs_disable
-# define statfs statfs_disable
-#endif
#include <sys/statfs.h>
#include <kernel-features.h>
@@ -87,9 +78,3 @@ weak_alias (__statfs64, statfs64)
#undef __statfs
#undef statfs
-
-#if STATFS_IS_STATFS64
-weak_alias (__statfs64, __statfs)
-weak_alias (__statfs64, statfs)
-libc_hidden_ver (__statfs64, __statfs)
-#endif
@@ -18,4 +18,3 @@
#define STAT_IS_KERNEL_STAT 1
#define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0