Message ID | 20200523191809.19663-1-aurelien.aptel@gmail.com |
---|---|
State | Committed |
Commit | 74edc05817c126212c826c1a046a9465d0efe287 |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3A379384B0C0; Sat, 23 May 2020 19:18:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A379384B0C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1590261525; bh=qBwRi1FXET8wVWL5MlblcEO1+1xJBg45O8H41ANN6Pw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=OTJ/NEt7IqeoL/B7dh9J8UyLjPVfVOugJ9aSceX4y4gJfiyBdiXAmaPGLoafJcnPD Q+AAYzQX2nZGEv+KgD7/B/sH0N6CNIrj6J0oWInYxmtt2ugvI1sOCPay9mpBY6GsSv sJTyho1KO2kUdDA6YQiEWtQIDpYgyO5xvDXIrbHE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 950A9385C426 for <libc-alpha@sourceware.org>; Sat, 23 May 2020 19:18:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 950A9385C426 Received: by mail-ot1-x335.google.com with SMTP id d26so10929888otc.7 for <libc-alpha@sourceware.org>; Sat, 23 May 2020 12:18:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qBwRi1FXET8wVWL5MlblcEO1+1xJBg45O8H41ANN6Pw=; b=JNdKA603KPWCaF9Tmz0EJ9ErNAmmCio07pT61yPDcT1JQlARdARp9KJhZukuJeGPMw vUZWIK2XFqPZ7xrYAH1As4vacSE9vUUR7aadmktVUERM5140kApfeEOqgh4PXukCSXp8 6nMQ/CZMQucJWrIPtNrK1iMHa6+PphojG7Kd5IIgDmzA0HTHINCgs4NXAWbMw8AXDILS CVNO94eI+rs+Ku7wcYGQqlIBpV86mCI2dX7AWUkrMOaUWjA3zowcwEBm2fGJMSA+LPPC 0PBbLD2rbaRScb2A8G/xkqEiqcUqQUbVwiEcns2v5fAB6D3DbmSLvUb6roebkZbZHTAP 7fZw== X-Gm-Message-State: AOAM5336QJ1P+iabCI4koTp65MhlSYLrBnLjG//c1dt1sV+yy9R+WE94 /XYj6PZw9+OznyiG45yKneULsxYS X-Google-Smtp-Source: ABdhPJxfjmw2NZFJWGVoBCf53M+Wf/VSvUFcGQk+drAj3hoTkoc9VDYk9I4E/8ajYhtsQs9tacHBjQ== X-Received: by 2002:a9d:d07:: with SMTP id 7mr16083323oti.338.1590261521938; Sat, 23 May 2020 12:18:41 -0700 (PDT) Received: from localhost (p200300fa070f6966174671e7c9252d4c.dip0.t-ipconnect.de. [2003:fa:70f:6966:1746:71e7:c925:2d4c]) by smtp.gmail.com with ESMTPSA id 60sm3552659otr.25.2020.05.23.12.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2020 12:18:41 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] manual/jobs.texi: remove unused var from example code Date: Sat, 23 May 2020 21:18:09 +0200 Message-Id: <20200523191809.19663-1-aurelien.aptel@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Aurelien Aptel via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Aurelien Aptel <aurelien.aptel@gmail.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
manual/jobs.texi: remove unused var from example code
|
|
Commit Message
Aurélien Aptel
May 23, 2020, 7:18 p.m. UTC
The do_job_notification() function defines a variable without using it. Remove it. --- manual/job.texi | 1 - 1 file changed, 1 deletion(-)
Comments
ping On Sat, May 23, 2020 at 9:18 PM Aurelien Aptel <aurelien.aptel@gmail.com> wrote: > > The do_job_notification() function defines a variable without using > it. Remove it. > --- > manual/job.texi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/manual/job.texi b/manual/job.texi > index 05a42ea820..42cb9fb26d 100644 > --- a/manual/job.texi > +++ b/manual/job.texi > @@ -860,7 +860,6 @@ void > do_job_notification (void) > @{ > job *j, *jlast, *jnext; > - process *p; > > /* @r{Update status information for child processes.} */ > update_status (); > -- > 2.26.2 >
On 5/23/20 3:18 PM, Aurelien Aptel via Libc-alpha wrote: > The do_job_notification() function defines a variable without using > it. Remove it. OK for master. Reviewed-by: Carlos O'Donell <carlos@redhat.com> > --- > manual/job.texi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/manual/job.texi b/manual/job.texi > index 05a42ea820..42cb9fb26d 100644 > --- a/manual/job.texi > +++ b/manual/job.texi > @@ -860,7 +860,6 @@ void > do_job_notification (void) > @{ > job *j, *jlast, *jnext; > - process *p; > > /* @r{Update status information for child processes.} */ > update_status (); >
* Carlos O'Donell via Libc-alpha: > On 5/23/20 3:18 PM, Aurelien Aptel via Libc-alpha wrote: >> The do_job_notification() function defines a variable without using >> it. Remove it. > > OK for master. > > Reviewed-by: Carlos O'Donell <carlos@redhat.com> Are you going to apply this? If you do, please be careful because due to the mailing list mangling, you cannot use “git am”. Thanks, Florian
On 6/3/20 5:07 PM, Florian Weimer wrote: > * Carlos O'Donell via Libc-alpha: > >> On 5/23/20 3:18 PM, Aurelien Aptel via Libc-alpha wrote: >>> The do_job_notification() function defines a variable without using >>> it. Remove it. >> >> OK for master. >> >> Reviewed-by: Carlos O'Donell <carlos@redhat.com> > > Are you going to apply this? I am. > If you do, please be careful because due to the mailing list mangling, > you cannot use “git am”. Patchwork sees things before mangling, and my workflow takes advantage of that. # git-pw patch apply 39357; *AND* for the gold star, it auto-applies my reviewed-by line because patchwork is tracking them (along with other tags). commit 74edc05817c126212c826c1a046a9465d0efe287 (HEAD -> master) Author: Aurélien Aptel <aurelien.aptel@gmail.com> Date: Sat May 23 21:18:09 2020 +0200 manual/jobs.texi: remove unused var from example code The do_job_notification() function defines a variable without using it. Remove it. Reviewed-by: Carlos O'Donell <carlos@redhat.com> commit a7a3435c9a0769744c7748f9d95510d0a99be7d1 (origin/master, origin/HEAD) ... Isn't that nice! Just built the manual, and verified the pdf looks good. Commited.
Great, thanks for applying the patch. While reading and using this doc I also found a more important bug in the example code, for which a bug was already opened 3 years ago but not addressed: https://sourceware.org/bugzilla/show_bug.cgi?id=22590 The sample code in the doc *cannot* work if SIGCHLD is ignored. The quick fix would be to simply remove the `signal (SIGCHLD, SIG_IGN);` line from Section 28.6.2 Initializing the Shell. I've personally lost a lot of time on this... I can send a patch for that if you'd like. Cheers,
diff --git a/manual/job.texi b/manual/job.texi index 05a42ea820..42cb9fb26d 100644 --- a/manual/job.texi +++ b/manual/job.texi @@ -860,7 +860,6 @@ void do_job_notification (void) @{ job *j, *jlast, *jnext; - process *p; /* @r{Update status information for child processes.} */ update_status ();