Message ID | 87tv0aaago.fsf@oldenburg2.str.redhat.com |
---|---|
State | Committed |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BFBE5394BE2C; Wed, 20 May 2020 15:32:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BFBE5394BE2C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1589988760; bh=Q3Zu8nv6pHYMdyjnmnHeR+3OC4RclhwgBbLcoZN0er0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=sadjugclhVGkSCBXKQJNfL4b0jn9ryOYdC/Le+2rdX9Ze0uFXslgbmU1V2nx+MHhU nQ91HkWAuNnc/cXieYugoxuN/0ThE0ToPmVkYJxSQUbJrTiVa+G13DvWN6Awxcb/ef 5Sh9f9t707hAokh1x6ugluI/usg66I/rKFYhjxVQ= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id BBECB3851C25 for <libc-alpha@sourceware.org>; Wed, 20 May 2020 15:32:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BBECB3851C25 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-Ehgn1-AmMBulZdTwrlcwNw-1; Wed, 20 May 2020 11:32:27 -0400 X-MC-Unique: Ehgn1-AmMBulZdTwrlcwNw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C0B8800053; Wed, 20 May 2020 15:32:26 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-191.ams2.redhat.com [10.36.113.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66C9D5D9E2; Wed, 20 May 2020 15:32:25 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH] Linux: Add missing handling of tai field to __ntp_gettime64 Date: Wed, 20 May 2020 17:32:23 +0200 Message-ID: <87tv0aaago.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FOREIGN_SUBJECT, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Florian Weimer <fweimer@redhat.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
Linux: Add missing handling of tai field to __ntp_gettime64
|
|
Commit Message
Florian Weimer
May 20, 2020, 3:32 p.m. UTC
This fixes a build error: ../sysdeps/unix/sysv/linux/ntp_gettime.c: In function ‘__ntp_gettime’: ../sysdeps/unix/sysv/linux/ntp_gettime.c:56:10: error: ‘ntv64.tai’ is used uninitialized in this function [-Werror=uninitialized] 56 | *ntv = valid_ntptimeval64_to_ntptimeval (ntv64); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- Testing on x86_64-linux-gnu, i686-linux-gnu and building with build-many-glibcs.py is under way. sysdeps/unix/sysv/linux/ntp_gettime.c | 1 + 1 file changed, 1 insertion(+)
Comments
On Wed, 20 May 2020, Florian Weimer via Libc-alpha wrote: > This fixes a build error: > > ../sysdeps/unix/sysv/linux/ntp_gettime.c: In function ‘__ntp_gettime’: > ../sysdeps/unix/sysv/linux/ntp_gettime.c:56:10: error: ‘ntv64.tai’ is used uninitialized in this function [-Werror=uninitialized] > 56 | *ntv = valid_ntptimeval64_to_ntptimeval (ntv64); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > --- > Testing on x86_64-linux-gnu, i686-linux-gnu and building with > build-many-glibcs.py is under way. OK.
* Joseph Myers: > On Wed, 20 May 2020, Florian Weimer via Libc-alpha wrote: > >> This fixes a build error: >> >> ../sysdeps/unix/sysv/linux/ntp_gettime.c: In function ‘__ntp_gettime’: >> ../sysdeps/unix/sysv/linux/ntp_gettime.c:56:10: error: ‘ntv64.tai’ is used uninitialized in this function [-Werror=uninitialized] >> 56 | *ntv = valid_ntptimeval64_to_ntptimeval (ntv64); >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> --- >> Testing on x86_64-linux-gnu, i686-linux-gnu and building with >> build-many-glibcs.py is under way. > > OK. Thanks, pushed after successful testing. Florian
Hi Florian, > This fixes a build error: > > ../sysdeps/unix/sysv/linux/ntp_gettime.c: In function ‘__ntp_gettime’: > ../sysdeps/unix/sysv/linux/ntp_gettime.c:56:10: error: ‘ntv64.tai’ is > used uninitialized in this function [-Werror=uninitialized] 56 | > *ntv = valid_ntptimeval64_to_ntptimeval (ntv64); | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > --- > Testing on x86_64-linux-gnu, i686-linux-gnu and building with > build-many-glibcs.py is under way. > > sysdeps/unix/sysv/linux/ntp_gettime.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sysdeps/unix/sysv/linux/ntp_gettime.c > b/sysdeps/unix/sysv/linux/ntp_gettime.c index 8ce5d13e00..2fdc6feb31 > 100644 --- a/sysdeps/unix/sysv/linux/ntp_gettime.c > +++ b/sysdeps/unix/sysv/linux/ntp_gettime.c > @@ -40,6 +40,7 @@ __ntp_gettime64 (struct __ntptimeval64 *ntv) > ntv->time = tntx.time; > ntv->maxerror = tntx.maxerror; > ntv->esterror = tntx.esterror; > + ntv->tai = tntx.tai; > return result; > } > > Thanks for preparing the fix. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/sysdeps/unix/sysv/linux/ntp_gettime.c b/sysdeps/unix/sysv/linux/ntp_gettime.c index 8ce5d13e00..2fdc6feb31 100644 --- a/sysdeps/unix/sysv/linux/ntp_gettime.c +++ b/sysdeps/unix/sysv/linux/ntp_gettime.c @@ -40,6 +40,7 @@ __ntp_gettime64 (struct __ntptimeval64 *ntv) ntv->time = tntx.time; ntv->maxerror = tntx.maxerror; ntv->esterror = tntx.esterror; + ntv->tai = tntx.tai; return result; }