diff mbox series

NEWS update about buffer overflow detection with GCC 10

Message ID dde7b086-7cea-82e7-9b55-98edc723f553@gmail.com
State Committed
Headers
Series NEWS update about buffer overflow detection with GCC 10 |

Commit Message

Martin Sebor May 12, 2020, 7:04 p.m. UTC 
  If this is in line with Glibc's practices, I'd like to add a brief
mention in the NEWS of file the recent enhancement to annotate some
Glibc APIs with GCC 10 attribute access.

How does the paragraph below sound?

Martin


  * The deprecated <sys/sysctl.h> header and the sysctl function have been

Comments

Adam Sampson May 12, 2020, 11:53 p.m. UTC | #1 
Martin Sebor via Libc-alpha <libc-alpha@sourceware.org> writes:

> +  a number of APIs have been annotated with GCC attribute accesss.  This
> +  allows GCC 10 to issue warnings for a greater subset such accesses
> +  than previous versions.

"greater subset *of*"?
develop--- via Libc-alpha May 14, 2020, 4:17 p.m. UTC | #2 
On Wed, 2020-05-13 at 00:53 +0100, Adam Sampson via Libc-alpha wrote:
> Martin Sebor via Libc-alpha <libc-alpha@sourceware.org> writes:
> 
> > +  a number of APIs have been annotated with GCC attribute accesss.  This
> > +  allows GCC 10 to issue warnings for a greater subset such accesses
> > +  than previous versions.
> 
> "greater subset *of*"?
Seems fine after that minor edit.

jeff
Martin Sebor May 19, 2020, 12:29 a.m. UTC | #3 
Let me put the question differently: is anyone opposed to making this
NEWS update?  Or are there suggestions for phrasing it differently?

Marti

On 5/12/20 1:04 PM, Martin Sebor wrote:
> If this is in line with Glibc's practices, I'd like to add a brief
> mention in the NEWS of file the recent enhancement to annotate some
> Glibc APIs with GCC 10 attribute access.
> 
> How does the paragraph below sound?
> 
> Martin
> 
> 
> diff --git a/NEWS b/NEWS
> index 141078c319..5c5f099566 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -23,6 +23,11 @@ Major new features:
>     toolchains.  It is recommended to use GCC 8 or newer when testing
>     this option.
> 
> +* To help detect buffer overflows and other out-of-bounds accesses
> +  a number of APIs have been annotated with GCC attribute accesss.  This
> +  allows GCC 10 to issue warnings for a greater subset such accesses
> +  than previous versions.
> +
>   Deprecated and removed features, and other changes affecting 
> compatibility:
> 
>   * The deprecated <sys/sysctl.h> header and the sysctl function have been
Paul Eggert May 19, 2020, 12:35 a.m. UTC | #4 
On 5/18/20 5:29 PM, Martin Sebor via Libc-alpha wrote:
> 
> +* To help detect buffer overflows and other out-of-bounds accesses
> +  a number of APIs have been annotated with GCC attribute accesss.  This
> +  allows GCC 10 to issue warnings for a greater subset such accesses
> +  than previous versions.

I suggest rewording lines 2-3 as follows. (This is just English-language 
wordsmithing; the point of the NEWS item sounds good to me.)

   several APIs have been annotated with the GCC 'access' attribute.
   This should help GCC 10 issue better warnings.
Martin Sebor May 20, 2020, 3:43 p.m. UTC | #5 
On 5/18/20 6:35 PM, Paul Eggert wrote:
> On 5/18/20 5:29 PM, Martin Sebor via Libc-alpha wrote:
>>
>> +* To help detect buffer overflows and other out-of-bounds accesses
>> +  a number of APIs have been annotated with GCC attribute accesss.  This
>> +  allows GCC 10 to issue warnings for a greater subset such accesses
>> +  than previous versions.
> 
> I suggest rewording lines 2-3 as follows. (This is just English-language 
> wordsmithing; the point of the NEWS item sounds good to me.)
> 
>    several APIs have been annotated with the GCC 'access' attribute.
>    This should help GCC 10 issue better warnings.

Sounds good.  I just pushed the updated change.

Thank you!
Martin
diff mbox series

Patch

diff --git a/NEWS b/NEWS
index 141078c319..5c5f099566 100644
--- a/NEWS
+++ b/NEWS
@@ -23,6 +23,11 @@  Major new features:
    toolchains.  It is recommended to use GCC 8 or newer when testing
    this option.

+* To help detect buffer overflows and other out-of-bounds accesses
+  a number of APIs have been annotated with GCC attribute accesss.  This
+  allows GCC 10 to issue warnings for a greater subset such accesses
+  than previous versions.
+
  Deprecated and removed features, and other changes affecting 
compatibility: