Message ID | dde7b086-7cea-82e7-9b55-98edc723f553@gmail.com |
---|---|
State | Committed |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 056B438708CA; Tue, 12 May 2020 19:04:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 056B438708CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1589310258; bh=B93/1ls/zf8AxIj95vpipLBgqzxVaMP3lP6OYKFrwEs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=dCYv57o/OzX2c28zy1yNa+aBNoAbWDkEuhscAFyVLc0jGuBk0kLv0k2rMOK3EvC2m IIvxHCj2c/7RZ+lupBnwYzkSrpwq5rVcIl/TRiJPlmgmlYJZ3xkqL8q8jXFNBlvzz0 8kgTv/VygVYWoRZ0P4Rff7L109V1vrs9g3vOk/iw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by sourceware.org (Postfix) with ESMTPS id 97787387084C for <libc-alpha@sourceware.org>; Tue, 12 May 2020 19:04:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 97787387084C Received: by mail-qk1-x729.google.com with SMTP id f83so14786869qke.13 for <libc-alpha@sourceware.org>; Tue, 12 May 2020 12:04:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=B93/1ls/zf8AxIj95vpipLBgqzxVaMP3lP6OYKFrwEs=; b=FBntBx0Plfm4NxVsY8qbxTDszG+lXe+bgcjYLQt9cUTTtlWUqyRWUZKUnjk5ImHu0F TZJ38X8fKmFxXLDHVXMWHr4DBsAHvP37yDK9ng+fBk7rdljTO/nz+I4XZwBx3IE0CGL9 I4eiGkizbCpNXEu57ECfinEa+af7bbM2gOl89XKHpKGSMpTbZNKjpPNt4HoYVfY43B1I hp0531Tk2Q7r5rZIs5C6kP4CAL+ZBWNvVq5PotibUeiV5ID3CetZDwSqAMmfO2kygclk AsRdGSc3EG+r9euZeewYykaoPxlajOO9aP0HNA/puDoDCTW1OL8WA2WIVogYhfjzwnDf KGcQ== X-Gm-Message-State: AGi0PubeiOgrdV1LXBlAuUTCtnKryfnvbzGWl4p5Pms5jOxp93EdV6RT 5VZufS/Iy02FNp/P2ZYnhqcfjidw X-Google-Smtp-Source: APiQypIDwYFYJB8xLhPNojJPZc0+JiiTy963L6468YY2ZaKZWOhVn+GxYKUljpLNo0gJU0YmD5SIOg== X-Received: by 2002:a37:5b44:: with SMTP id p65mr14997314qkb.283.1589310255290; Tue, 12 May 2020 12:04:15 -0700 (PDT) Received: from [192.168.0.41] (174-16-121-251.hlrn.qwest.net. [174.16.121.251]) by smtp.gmail.com with ESMTPSA id a190sm7501902qkc.118.2020.05.12.12.04.14 for <libc-alpha@sourceware.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2020 12:04:14 -0700 (PDT) To: GNU C Library <libc-alpha@sourceware.org> Subject: NEWS update about buffer overflow detection with GCC 10 Message-ID: <dde7b086-7cea-82e7-9b55-98edc723f553@gmail.com> Date: Tue, 12 May 2020 13:04:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Martin Sebor via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Martin Sebor <msebor@gmail.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
NEWS update about buffer overflow detection with GCC 10
|
|
Commit Message
Martin Sebor
May 12, 2020, 7:04 p.m. UTC
If this is in line with Glibc's practices, I'd like to add a brief mention in the NEWS of file the recent enhancement to annotate some Glibc APIs with GCC 10 attribute access. How does the paragraph below sound? Martin * The deprecated <sys/sysctl.h> header and the sysctl function have been
Comments
Martin Sebor via Libc-alpha <libc-alpha@sourceware.org> writes: > + a number of APIs have been annotated with GCC attribute accesss. This > + allows GCC 10 to issue warnings for a greater subset such accesses > + than previous versions. "greater subset *of*"?
On Wed, 2020-05-13 at 00:53 +0100, Adam Sampson via Libc-alpha wrote: > Martin Sebor via Libc-alpha <libc-alpha@sourceware.org> writes: > > > + a number of APIs have been annotated with GCC attribute accesss. This > > + allows GCC 10 to issue warnings for a greater subset such accesses > > + than previous versions. > > "greater subset *of*"? Seems fine after that minor edit. jeff
Let me put the question differently: is anyone opposed to making this NEWS update? Or are there suggestions for phrasing it differently? Marti On 5/12/20 1:04 PM, Martin Sebor wrote: > If this is in line with Glibc's practices, I'd like to add a brief > mention in the NEWS of file the recent enhancement to annotate some > Glibc APIs with GCC 10 attribute access. > > How does the paragraph below sound? > > Martin > > > diff --git a/NEWS b/NEWS > index 141078c319..5c5f099566 100644 > --- a/NEWS > +++ b/NEWS > @@ -23,6 +23,11 @@ Major new features: > toolchains. It is recommended to use GCC 8 or newer when testing > this option. > > +* To help detect buffer overflows and other out-of-bounds accesses > + a number of APIs have been annotated with GCC attribute accesss. This > + allows GCC 10 to issue warnings for a greater subset such accesses > + than previous versions. > + > Deprecated and removed features, and other changes affecting > compatibility: > > * The deprecated <sys/sysctl.h> header and the sysctl function have been
On 5/18/20 5:29 PM, Martin Sebor via Libc-alpha wrote: > > +* To help detect buffer overflows and other out-of-bounds accesses > + a number of APIs have been annotated with GCC attribute accesss. This > + allows GCC 10 to issue warnings for a greater subset such accesses > + than previous versions. I suggest rewording lines 2-3 as follows. (This is just English-language wordsmithing; the point of the NEWS item sounds good to me.) several APIs have been annotated with the GCC 'access' attribute. This should help GCC 10 issue better warnings.
On 5/18/20 6:35 PM, Paul Eggert wrote: > On 5/18/20 5:29 PM, Martin Sebor via Libc-alpha wrote: >> >> +* To help detect buffer overflows and other out-of-bounds accesses >> + a number of APIs have been annotated with GCC attribute accesss. This >> + allows GCC 10 to issue warnings for a greater subset such accesses >> + than previous versions. > > I suggest rewording lines 2-3 as follows. (This is just English-language > wordsmithing; the point of the NEWS item sounds good to me.) > > several APIs have been annotated with the GCC 'access' attribute. > This should help GCC 10 issue better warnings. Sounds good. I just pushed the updated change. Thank you! Martin
diff --git a/NEWS b/NEWS index 141078c319..5c5f099566 100644 --- a/NEWS +++ b/NEWS @@ -23,6 +23,11 @@ Major new features: toolchains. It is recommended to use GCC 8 or newer when testing this option. +* To help detect buffer overflows and other out-of-bounds accesses + a number of APIs have been annotated with GCC attribute accesss. This + allows GCC 10 to issue warnings for a greater subset such accesses + than previous versions. + Deprecated and removed features, and other changes affecting compatibility: